Simplify synchronization in VulkanRenderManager #16090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
added
Vulkan
Code Cleanup
|
OK, had to reintroduce one frame-specific cond-var. Still, this actually provides a very small but measurable speedup (600 fps to 610 fps on a GoW title screen). Will test some more before merge. |
hrydgard
commented
Sep 23, 2022
|
I think this is pretty much ready to go now. |
unknownbrackets
approved these changes
Sep 24, 2022
There was a problem hiding this comment.
This looks good but it's still breaking in the disassembly as it was before (note: not the GE debugger.)
Reproduction:
- Start a game.
- Open Disassembly.
- Hit Break.
- Hit Go.
Always crashes. Anyway, this doesn't make that any worse than before and seems better. I tried a couple runs and haven't gotten the readyForFences error or any other failures/deadlocks.
-[Unknown]
|
Found and added a fix/workaround for the crash here: #16092. -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies thread synchronization in the Vulkan rendering backend, making it easier to reason about and debug, and very slightly faster. Tested the GE debugger, seems fine.
Now uses a queue where we tell the render thread what to do, instead of maintaining a separate frame counter.
Also there's an issue when stuffing the queue, it's not allowed to wait on a fence if the submission that is going to trigger it is currently happening on another thread, I missed that. And using a regular mutex easily deadlocks (working on it).