Fix green flashes with Burnout Dominator lens flare #16081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
force-pushed
the
zbuffer-upload-heuristic
branch
from
6bba7ce
to
a31c5c8
Compare
| if (PSP_CoreParameter().compat.flags().UploadDepthForCLUTTextures && (currentRenderVfb_->usageFlags & FB_USAGE_CLUT) != 0) { | ||
| // Set the flag, then upload memory contents to depth channel. | ||
| // Special compatibility trick for Burnout Dominator lens flares. See issue #11100 | ||
| if (PSP_CoreParameter().compat.flags().UploadDepthForCLUTTextures && currentRenderVfb_->z_address > 0x04110000) { |
There was a problem hiding this comment.
What if we did this only when vfb->lastFrameNewSize == gpuStats.numFlips rather than based on the z_address? Would that work?
We do PerformStencilUpload / PerformMemoryUpload when creating a framebuf, I don't think it'd be so awful to also upload depth, and might allow it to be more generic.
-[Unknown]
There was a problem hiding this comment.
Hm, I could try that. I guess since this Z buffer is static, only uploading it on create/resize would work. I previously tried uploading it on create and it didn't work, but I didn't realize then that it was because the resize later ruined it...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16075
Checking the CLUT-usage flag is a frame too late when the buffer is just created (which does happen quite often, since we aggressively delete unused framebuffers and the lens flare is not always on screen).
Additionally, the color buffer copy to the CLUT buffer causes a resize, where we used to lose the Z buffer, so it would be gone anyway the first frame. This fixes that by copying the depth buffer in this case. Hopefully won't slow anything else down noticeably.