Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code optimization for dropout operation #3

Open
hi-zhengcheng opened this issue Nov 7, 2019 · 0 comments
Open

Code optimization for dropout operation #3

hi-zhengcheng opened this issue Nov 7, 2019 · 0 comments

Comments

@hi-zhengcheng
Copy link

Thanks for your nice work. I just read through the code and find a small problem in dropout operation:

layer_fts = tf.layers.dropout(layer_fts, rate=dropout_rate, name='fc{:d}_dropout'.format(layer_idx))

Actually this dropout operation has no effect if you don't pass training=is_training to it. The default value for training parameter is False so it will return the input untouched.

But it's ok, it doesn’t influence the experiment. Maybe you can fix it in your spare time, or just remove dropout to make code clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant