Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Refactor Idea: Split code into smaller parts #172

Open
steveiliop56 opened this issue Sep 17, 2024 · 1 comment
Open

Code Refactor Idea: Split code into smaller parts #172

steveiliop56 opened this issue Sep 17, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@steveiliop56
Copy link
Contributor

Hello,

It's really nice that you managed to bundle the entire agent in one file, 600 lines long lmao. While experienced users may be able to navigate around it, new contributors may find it difficult to add features. I believe a better approach would be to split everything (agent, hub, site) into multiple files so it's easier to navigate. For example the UI could be split into multiple components each component doing a specific thing. Additionally the agent can be again split into 2-3 files for the data fetching, data sending etc. The hub can stay as is I believe since it's relatively small. Additionally it could be useful to add more comments : ). That's definitely a future idea but it would be a solid refactor. I can start adding some comments here and there if you like.

@henrygd
Copy link
Owner

henrygd commented Sep 17, 2024

Comments are welcome, thanks.

I plan to do an update at some point that is just refactoring and adding tests.

It's actually quite a bit better organized now than it was a couple months ago, but obviously there is still a lot of improvements to be made.

@henrygd henrygd added the enhancement New feature or request label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants