Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deletion protection for google_alloydb_cluster #19651

Open
nblxa opened this issue Sep 26, 2024 · 0 comments
Open

Add deletion protection for google_alloydb_cluster #19651

nblxa opened this issue Sep 26, 2024 · 0 comments
Labels
enhancement forward/review In review; remove label to forward service/alloydb

Comments

@nblxa
Copy link

nblxa commented Sep 26, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

Currently, google_alloydb_cluster doesn't implement a deletion protection flag (such as in google_sql_database_instance, for example). This may cause data loss in situations when the cluster is destroyed or replaced by mistake.

Please note that Terraform's own prevent_destroy flag may not be used with variables, so it would not be a full replacement of the deletion protection flag on the resource. See the linked issue.

New or Affected Resource(s)

  • google_alloydb_cluster

Potential Terraform Configuration

resource "google_alloydb_cluster" "default" {
  cluster_id = "alloydb-cluster"
  location   = "us-central1"
  network_config {
    network = google_compute_network.default.id
  }
  deletion_protection = var.alloydb_deletion_protection
}

variable "cloudsql_deletion_protection" {}

References

hashicorp/terraform#22544

@github-actions github-actions bot added forward/review In review; remove label to forward service/alloydb labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement forward/review In review; remove label to forward service/alloydb
Projects
None yet
Development

No branches or pull requests

1 participant