Browser-compatibility fix for data URI scheme. #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since MSIE cuts off URL's validated in this way at 5120 bytes, data URI's should not be qualified this way. This bugfix allows you to use base64-encoded data URI's for audio data.
As of Chrome version 37, the Android bugfix appears to be no longer needed, and in fact breaks jPlayer. This is the fix.
|
This PR is polluted with a fix for android / chrome. That fix was implemented in another manner in 2.7.1 and while I accept that Chrome 37+ on Android may not need the fix applied at all, I tend to try and avoid the browser sniffer where possible. BTW, the fix for android in 2.7.1 was to simply change the detection event from I should be able to merge in the commit hash for the data: url fix so that you get contributor credit. Would you please sign the CLA so that I may merge this when I'm ready. |
thepag
added a commit
that referenced
this pull request
Nov 20, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since MSIE cuts off URL's validated in this way at 5120 bytes, data URI's should not be qualified this way. This fix allows you to use base64-encoded data URI's for audio data.