Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce TRM_CONCEPT_DESIG.VAL_VC column to replace VAL #6080

Merged
merged 9 commits into from
Jul 8, 2024
Merged

Introduce TRM_CONCEPT_DESIG.VAL_VC column to replace VAL #6080

merged 9 commits into from
Jul 8, 2024

Conversation

lukedegruchy
Copy link
Collaborator

@lukedegruchy lukedegruchy commented Jul 4, 2024 •
edited
Loading

  • Add a new String column with length = Length.LONG32
  • In the migration, add the column of type TEXT
  • Change the getter to retrieve the new column if it's non-null, otherwise, the old one
  • Always write to the new column

Closes #6079

@lukedegruchy lukedegruchy requested a review from a team as a code owner July 4, 2024 19:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

Formatting check succeeded!

@lukedegruchy lukedegruchy changed the title Extend TRM_CONCEPT_DESIG.VAL column from 2,000 to 4,000 characters. Introduce TRM_CONCEPT_DESIG.VAL_VC column to replace VAL Jul 5, 2024
@lukedegruchy lukedegruchy enabled auto-merge (squash) July 8, 2024 13:26
@lukedegruchy lukedegruchy merged commit ef0aa11 into master Jul 8, 2024
63 of 64 checks passed
@lukedegruchy lukedegruchy deleted the ld-20240704-term-concept-designation-val-over-2000-chars branch July 8, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadgh tadgh tadgh approved these changes

@epeartree epeartree epeartree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to save TermConceptDesignation.value over 2,000 characters
3 participants
@lukedegruchy @tadgh @epeartree