Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad MFA on interactive login throwing Unknown #114

Open
jeeftor opened this issue Aug 16, 2024 · 1 comment
Open

Bad MFA on interactive login throwing Unknown #114

jeeftor opened this issue Aug 16, 2024 · 1 comment

Comments

@jeeftor
Copy link

jeeftor commented Aug 16, 2024

When you enter a bad MFA we're getting a 404 for resp.status but the parsing of the error code isn't correct

It appears this code block is incorrect:

image

And we need to raise an MFA exception instead of an "Unknown error"

image

aka:

image

Maybe something like:

if response["detail"] == 'Your code was invalid, please try again or use a recovery token.':
   raise RequireMFAException("Your code was invalid, please try again or use a recovery token")

or

if 'please try again' in response['detail']:
   raise RequireMFAException("Your code was invalid, please try again or use a recovery token")
@jeeftor jeeftor changed the title Bad MFA doesn't work correctly Bad MFA on interactive login throwing Unknown Aug 16, 2024
@jeeftor
Copy link
Author

jeeftor commented Aug 16, 2024

Yes I've verified this in the browser as well:

MFA Required initial error
image

Bad MFA Given:
image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant