Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack notification formatting issues - 0.18.14 #9986

Closed
data-han opened this issue May 29, 2024 · 6 comments · Fixed by #10130 or #10129
Closed

Slack notification formatting issues - 0.18.14 #9986

data-han opened this issue May 29, 2024 · 6 comments · Fixed by #10130 or #10129
Assignees
Labels
bug Bugs bugs bugs! feature:slack_notification Issues and PRs related to the Slack notification feature

Comments

@data-han
Copy link

Is your feature request related to a problem? Please describe.
I'm just checking in with regards to the new update 0.18.14 on the new slack design. Awesome to have a new look but i would want to check if we could make it better since this is largely used across by everyone

Describe the solution you'd like
#9952
image

I wrote in the feature PR regarding this but not sure if it is 'closed' and won't be looked after. Anyway, my team has been using this slack notification for a long time, it is serving our purpose quite well (except that it had this extra filepath issue, im not sure why is that??) . With the new update, it is not as clear as it was before to show the asset name etc

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context, screenshots, or code samples about the feature request here.

@Kilo59
Copy link
Member

Kilo59 commented May 29, 2024

@jshaikGX
Copy link
Contributor

This was fixed in 0.18.15
and yes the design is been updated to be simple now! Please try 0.18.15 and let us know if this is still a problem

@Kilo59 Kilo59 added the feature:slack_notification Issues and PRs related to the Slack notification feature label May 29, 2024
@data-han
Copy link
Author

@Kilo59 @jshaikGX

hello, thanks for looking into this. Much appreciate for your effort! I've tried 0.18.15 but i still see the same. May I know which issue is fixed? I'm still seeing the same except for UTC being added..

  • i still see a unexpected file path
  • Asset and Suite is not 'bolded'
image

@jshaikGX jshaikGX reopened this May 29, 2024
@Kilo59 Kilo59 reopened this May 29, 2024
@jshaikGX
Copy link
Contributor

Will have the team look into this!

@Kilo59 Kilo59 added the bug Bugs bugs bugs! label May 29, 2024
@Kilo59 Kilo59 changed the title [feature] Slack notification design 0.18.14 Slack notification formatting issues - 0.18.14 May 29, 2024
@data-han
Copy link
Author

data-han commented Jun 4, 2024

Adding the same issue raised a year ago. Not sure if anyone can help to visit this topic
#7016

@NathanFarmer
Copy link
Contributor

@data-han We removed the broken/duplicated link text, but we aren't able to have it show up as a hyperlink for local Data Docs, because Slack does not allow linking to local files due to security concerns. This fix will be available in version 0.18.20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs bugs bugs! feature:slack_notification Issues and PRs related to the Slack notification feature
Projects
None yet
5 participants