Fix DST issues in 0.9.x

[obfuscurity]

There are a number of DST issues that need to be addressed in 0.9.x before the next release. As mentioned by @brutassed here, he's already fixed a bunch of these in brutasse/graphite-api. These should be easily ported to master and 0.9.x.

Let's use this issue as a catch-all for any discussions around DST fixes.

brutasse/graphite-api@c8854f5
brutasse/graphite-api@a0ae470

Refs #753 #806 #807

[obfuscurity]

Also refs #639

[esc]

In case anyone is wondering, the two graphite-api commits need to be backported to fix the three issues.

[deniszh]

Hi @esc,
Could you please point to these commits please? :)

[obfuscurity]

@deniszh The two I linked in the original description.

[obfuscurity]

Related, courtesy of @mleinart (with approval to post):

[deniszh]

Nah, my fix is not working, @mleinart was right :)

Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "/opt/graphite/webapp/graphite/render/views.py", line 53, in renderView
    (graphOptions, requestOptions) = parseOptions(request)
  File "/opt/graphite/webapp/graphite/render/views.py", line 305, in parseOptions
    startTime = min(fromTime, untilTime)
TypeError: can't compare offset-naive and offset-aware datetimes

It seems time handling in Flask is much better, or @brutasse also fix this in different way...

[brutasse]

@deniszh there were 2 commits in graphite-api. The first one was incomplete, make sure you take both into account.

[deniszh]

Hm. It's working now, but not sure if I patched fetchData() right. @brutasse, could you please check ?

[deniszh]

More fixes after @brutasse advices. Will port to master w/proper testing today or on weekend.