Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor executor contexts? #2068

Open
na-- opened this issue Jun 17, 2021 · 0 comments
Open

Refactor executor contexts? #2068

na-- opened this issue Jun 17, 2021 · 0 comments
Labels
evaluation needed proposal needs to be validated or tested before fully implementing it in k6 refactor

Comments

@na--
Copy link
Member

na-- commented Jun 17, 2021

This originally started as a PR comment: #1863 (comment)

The context hierarchy is a bit unexpected, we have:

parentCtx -> maxDurationCtx -> regDurationCtx
                           \-> maxDurationCtxWithScenarioState -> vuCtx

So someone expecting to have the ScenarioState in regDurationCtx might be surprised. Something like this might be better:

parentCtx -> parentCtxWithScenarioState -> maxDurationCtx -> regDurationCtx
                                                         \-> vuCtx

Unfortunately, there are some implementation chicken-and-egg problems that were described in the PR thread 😞

Other somewhat related things:

@na-- na-- added refactor evaluation needed proposal needs to be validated or tested before fully implementing it in k6 labels Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
evaluation needed proposal needs to be validated or tested before fully implementing it in k6 refactor
Projects
None yet
Development

No branches or pull requests

1 participant