Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run e2e tests in debug/editor mode (in addition to prod mode) #893

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

wwwillchen
Copy link
Collaborator

Long overdue, but we should run our e2e tests in both prod and debug/editor mode to catch regressions, especially with all the editor toolbar changes.

This skips some of the e2e tests in debug mode, particularly those related to web security, because we have more lax web security policies when running in debug mode. We could run those tests in debug mode and maintain separate goldens (e.g. for CSPs), but this is a bit of work and doesn't seem too pressing.

Copy link
Collaborator

@richard-to richard-to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wwwillchen wwwillchen merged commit b6b2e51 into google:main Aug 29, 2024
5 checks passed
@wwwillchen wwwillchen deleted the editor-tests branch August 29, 2024 20:41
@wwwillchen wwwillchen mentioned this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants