Check isEmpty()
instead of size == 0
.
#7144
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check
isEmpty()
instead ofsize == 0
.That way is simpler.
It's also somewhat better for users who pass a filtered collection, but:
size
for more than an emptiness check).isEmpty
call, so that can still cause trouble if the filter has side effects or "call the filter until it returnstrue
" is slow enough to matter.Fixes #7143 (for now)
RELNOTES=n/a