Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebRTC Signaling demo doesn't load peers in debug/Windows build #677

Open
IsaaacD opened this issue Jan 20, 2022 · 1 comment
Open

WebRTC Signaling demo doesn't load peers in debug/Windows build #677

IsaaacD opened this issue Jan 20, 2022 · 1 comment
Labels

Comments

@IsaaacD
Copy link

IsaaacD commented Jan 20, 2022

Which demo project is affected:
WebRTC Signaling

OS/device including version:
Windows 10, Godot v3.4.2.stable.official

Issue description:
The peers don't get registered on the local WebRTCMultiplayer on windows as the connection state enum is set to closed. The documentation says that it requires to be open

Screenshots of issue:
This is a screenshot of printing peers on Windows/Debug. The WebRTCMultiplayer object doesn't have any peers:
image

To contrast this, this is what it looks like in a web browser where we can see additional messaging and peers listed:
image

I've checked the source code of WebRTCPeerConnection and there's a variant for JavaScript. The enum gets explicitly set as new during the initialize method, see here in JS but for other platforms it seems to not explicitly do this (sorry not too familiar with Godot's internal code so GDVIRTUAL_CALL(_initialize, p_config, err) might be doing it, not sure where that's implemented)

@IsaaacD IsaaacD added the bug label Jan 20, 2022
@Calinou
Copy link
Member

Calinou commented Jan 20, 2022

cc @Faless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants