-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LenSqr functions #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it has taken a while for someone to get back to you on this. I can't see anything wrong with this other than a minor bug in the automatically generated files. Can you rectify and I'll merge assuming there aren't any objections.
Thanks for fixing the issues I raised! One thing that occured to me as I go to merge it: How about Let me know what you think. Happy to accept it as is otherwise - though I will squash the history down to just "Add ... functions", to avoid the merge commit going from master into the development branch. |
I would expect autocomplete to list the function regardless of where in the name the substring is found, but regarding the documentation, you raise a good point. Maybe call it |
OK, then 👍 to |
Should be good now. |
Added SqrLen() functions which return squared vector length. This can make some lines shorter when variable names are long, e.g.:
worldSpaceFragmentCenter.Dot(worldSpaceFragmentCenter)
vs.
worldSpaceFragmentCenter.SqrLen()
Understandable if not wanted, though. Mostly learning how 2 github over here. Have a nice day.