Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for generating a JWT uses relatively unknown Python library #33796

Open
1 task done
altaurog opened this issue Jul 2, 2024 · 2 comments · May be fixed by #33797
Open
1 task done

Documentation for generating a JWT uses relatively unknown Python library #33796

altaurog opened this issue Jul 2, 2024 · 2 comments · May be fixed by #33797
Labels
content This issue or pull request belongs to the Docs Content team github apps Content related to GitHub Apps

Comments

@altaurog
Copy link

altaurog commented Jul 2, 2024

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app#example-using-python-to-generate-a-jwt

What part(s) of the article would you like to see updated?

The python code relies on the jwt library, which is comparatively unknown. I think a better choice for github documentation is the more widely-recognized and used PyJWT library. The code would be more simple, and the library is more highly regarded:

library github stars libraries.io SourceRank snyk Package Health Score
jwt 137 18 58 / 100
PyJWT 4988 22 91 / 100

Additional information

No response

@altaurog altaurog added the content This issue or pull request belongs to the Docs Content team label Jul 2, 2024
Copy link

welcome bot commented Jul 2, 2024

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 2, 2024
@altaurog altaurog linked a pull request Jul 2, 2024 that will close this issue
2 tasks
@nguyenalex836 nguyenalex836 added github apps Content related to GitHub Apps and removed triage Do not begin working on this issue until triaged by the team labels Jul 2, 2024
@nguyenalex836
Copy link
Contributor

@altaurog Thank you for opening an issue and linking it to your PR! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team github apps Content related to GitHub Apps
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants