Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: mismatch between explanation and code in triggers #33783

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs: mismatch between explanation and code in triggers #33783

wants to merge 2 commits into from
+2 −3

Conversation

gagan-bhullar-tech
Copy link
Contributor

Why: To fix mismatch between explanation and code in triggers

Closes: #33777

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 1, 2024
@gagan-bhullar-tech gagan-bhullar-tech changed the title docs: Mismatch between explanation and code in triggers docs: mismatch between explanation and code in triggers Jul 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/publishing-packages/publishing-docker-images.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team and removed triage Do not begin working on this issue until triaged by the team labels Jul 1, 2024
@nguyenalex836
Copy link
Contributor

@gagan-bhullar-tech Hello! 👋 Thank you for opening a PR!

We will need to put this PR on hold for now until the issue this PR is linked to has been reviewed by the team 💛

hubwriter
hubwriter requested changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gagan-bhullar-tech - Many thanks for raising this PR with these changes.

As a result of feedback we've had, we are currently making an effort to reduce the number of links between articles, except where necessary to the understanding of the current article, so I've suggested removing the links here.

If you'd like to click to commit my suggestions then I'll approve this and we can get this merged next week once the current repo freeze is lifted.

Thanks again for working on this.
👍

content/actions/publishing-packages/publishing-docker-images.md Outdated Show resolved Hide resolved
content/actions/publishing-packages/publishing-docker-images.md Outdated Show resolved Hide resolved
@hubwriter hubwriter mentioned this pull request Jul 2, 2024
Open
1 task
@gagan-bhullar-tech
Copy link
Contributor Author

gagan-bhullar-tech commented Jul 2, 2024 •
edited
Loading

@hubwriter thanks. Incorporated both changes.

@nguyenalex836 nguyenalex836 added the ready to merge This pull request is ready to merge label Jul 2, 2024
@hubwriter hubwriter enabled auto-merge July 3, 2024 08:39
@hubwriter
Copy link
Contributor

@gagan-bhullar-tech - Many thanks. We'll merge this next week after the current repo freeze is lifted.
🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubwriter hubwriter hubwriter approved these changes

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mismatch between explanation and code about triggers used
3 participants
@gagan-bhullar-tech @nguyenalex836 @hubwriter