read-cache: close index.lock in do_write_index #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teach do_write_index() to close the index.lock file before getting the mtime and updating the istate.timestamp fields. On Windows, a file's mtime is not updated until the file is closed. On Linux, the mtime is set after the last flush. Signed-off-by: Jeff Hostetler <[email protected]>
|
@dscho Here is an updated version of what we talked about this morning. It's mostly what you started with, but I updated the fstat() call at the bottom of do_write_index(). I'll save the optimization stuff for another PR. |
|
Thanks! We may want to suppress the error message when we failed to close, as the other failures are also silent. But that will be my Duck when submitting the patch upstream, always good to have a Duck. |
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Apr 26, 2017
When writing the Git index file, Git for Windows [no longer has the wrong idea about the file's timestamp](git-for-windows/git#1149). Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
Apr 26, 2017
…dex_mtime read-cache: close index.lock in do_write_index
dscho
added a commit
that referenced
this pull request
Apr 26, 2017
…dex_mtime read-cache: close index.lock in do_write_index
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 26, 2017
…dex_mtime read-cache: close index.lock in do_write_index
dscho
added a commit
that referenced
this pull request
May 4, 2017
…dex_mtime read-cache: close index.lock in do_write_index
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 10, 2017
…dex_mtime read-cache: close index.lock in do_write_index
dscho
added a commit
that referenced
this pull request
May 10, 2017
…dex_mtime read-cache: close index.lock in do_write_index
dscho
added a commit
that referenced
this pull request
May 10, 2017
…dex_mtime read-cache: close index.lock in do_write_index
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 16, 2017
…dex_mtime read-cache: close index.lock in do_write_index
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 23, 2017
…dex_mtime read-cache: close index.lock in do_write_index
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 23, 2017
…dex_mtime read-cache: close index.lock in do_write_index
dscho
added a commit
that referenced
this pull request
May 29, 2017
…dex_mtime read-cache: close index.lock in do_write_index
dscho
added a commit
that referenced
this pull request
May 30, 2017
…dex_mtime read-cache: close index.lock in do_write_index
dscho
added a commit
that referenced
this pull request
May 30, 2017
…dex_mtime read-cache: close index.lock in do_write_index
dscho
added a commit
that referenced
this pull request
Jun 5, 2017
…dex_mtime read-cache: close index.lock in do_write_index
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jun 7, 2017
…dex_mtime read-cache: close index.lock in do_write_index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teach do_write_index() to close the index.lock file
before getting the mtime and updating the istate.timestamp
fields.
On Windows, a file's mtime is not updated until the file is
closed. On Linux, the mtime is set after the last flush.
Signed-off-by: Jeff Hostetler [email protected]