Skip to content

Commit

Permalink
installer: add git.exe to the PATH by default, ignoring previous sett…
Browse files Browse the repository at this point in the history
…ings

Most users simply click through the installer and do not benefit from
our previous change that added `cmd/` to the PATH enabled by default,
because during an upgrade the previous setting (which was disabled by
default) would be replayed.

Let's skip replaying the previous setting for a couple of releases so
that users get to benefit from the new default.

Signed-off-by: Johannes Schindelin <[email protected]>
  • Loading branch information
dscho committed Apr 6, 2016
1 parent 95e4d28 commit 1e2e00e
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions installer/install.iss
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,6 @@ begin
Height:=ScaleY(17);
Font.Style:=[fsBold];
TabOrder:=0;
Checked:=True;
end;
LblGitBash:=TLabel.Create(PathPage);
with LblGitBash do begin
Expand All @@ -651,6 +650,7 @@ begin
Height:=ScaleY(17);
Font.Style:=[fsBold];
TabOrder:=1;
Checked:=True;
end;
LblGitCmd:=TLabel.Create(PathPage);
with LblGitCmd do begin
Expand Down Expand Up @@ -700,17 +700,6 @@ begin
Font.Style:=[fsBold];
end;
// Restore the setting chosen during a previous install.
Data:=ReplayChoice('Path Option','Cmd');
if Data='BashOnly' then begin
RdbPath[GP_BashOnly].Checked:=True;
end else if Data='Cmd' then begin
RdbPath[GP_Cmd].Checked:=True;
end else if Data='CmdTools' then begin
RdbPath[GP_CmdTools].Checked:=True;
end;
(*
* Create a custom page for using (Tortoise)Plink instead of OpenSSH
* if at least one PuTTY session is found in the Registry.
Expand Down

0 comments on commit 1e2e00e

Please sign in to comment.