Migrate entity.create.error audit action to entity.error #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktuite
force-pushed
the
ktuite/entity-error
branch
from
3a1d446
to
7b2588c
Compare
ktuite
force-pushed
the
ktuite/entity-error
branch
from
fd95833
to
9f59dea
Compare
matthew-white
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#520
Migrate
entity.create.errortoentity.errorand add new404.8Problem with descriptive error about entity UUID not found. Example:The entity with UUID (12345678-1234-4123-8234-123456789abc) specified in the submission does not exist in the dataset (people).What has been done to verify that this works as intended?
Tests, trying it in frontend.
Why is this the best possible solution? Were any other approaches considered?
It makes the most sense to have a generic entity processing error, so all previous
entity.create.errorerror events, which were the only possible processing errors before updates, have been migrated toentity.error.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Makes clearer errors. I don't think there are regression risks.
Does this change require updates to the API documentation? If so, please update docs/api.md as part of this PR.
Did make a small change the one place this error was mentioned in the documentation.
Before submitting this PR, please make sure you have:
make test-fulland confirmed all checks still pass OR confirm CircleCI build passes