This repository has been archived by the owner on Feb 12, 2023. It is now read-only.
Issue #455 Restore the Location header in HEAD pre-flight responses #466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #455
What has been done to verify that this works as intended?
Run Aggregate and use curl to verify that the
Location
header is in the response of the HEAD. I verified the two that can be accessed without auth and expect that the third will work because it has been changed the same way.Why is this the best possible solution? Were any other approaches considered?
This is the old code that's running in 1.7 slightly refactored into just one line.
Are there any risks to merging this code? If so, what are they?
It's a pretty straightforward change that doesn't affect any other behavior in Aggregate. I wouldn't expect any risk to merging this PR.
Do we need any specific form for testing your changes? If so, please attach one
No.
Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.
No.