linux: delete temp files as soon as they are not needed #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like I'm too agressive unlinking the file, I'll try to unlink it only after a new one is being set. |
meskio
force-pushed
the
unlink_temp_files
branch
from
50524b2
to
fde8676
Compare
meskio
changed the title
meskio
force-pushed
the
unlink_temp_files
branch
from
fde8676
to
b7080d7
Compare
Stop generating one file in /tmp for each icon change. Let's move the clean up to the set icon instead of waiting for the quit clean up.
meskio
force-pushed
the
unlink_temp_files
branch
from
b7080d7
to
d461324
Compare
TMPDIR is the canonical environment variable in Unix and POSIX that should be used to specify a temporary directory: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_03 Let's use it if is defined to store temporary icon files and default to '/tmp' if is not defined.
|
I have also added a commit to use |
leap-code-o-matic
pushed a commit
to leapcode/bitmask-vpn
that referenced
this pull request
Jan 24, 2019
Stop generating one file in /tmp for each icon change. Let's move the clean up to the set icon instead of waiting for the quit clean up. Unlink will remove the file from /tmp, but app_indicator will hold a descriptor until it finishes with it. This is a cherry-pick from a pull-request upstream: getlantern/systray#63 - Resolves: #60
ropog3ovomou
pushed a commit
to ropog3ovomou/systray
that referenced
this pull request
Jul 13, 2022
linux: delete temp files as soon as they are not needed
kalikaneko
pushed a commit
to leapcode/riseup-vpn-snap
that referenced
this pull request
Apr 21, 2024
Stop generating one file in /tmp for each icon change. Let's move the clean up to the set icon instead of waiting for the quit clean up. Unlink will remove the file from /tmp, but app_indicator will hold a descriptor until it finishes with it. This is a cherry-pick from a pull-request upstream: getlantern/systray#63 - Resolves: #60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop generating one file in /tmp for each icon change. Let's move the
clean up to the set icon instead of waiting for the quit clean up.
Unlink will remove the file from /tmp, but app_indicator will hold adescriptor until it finishes with it.