Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: gabrieldemarmiesse/python-on-whales
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.72.0
Choose a base ref
...
head repository: gabrieldemarmiesse/python-on-whales
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.73.0
Choose a head ref
  • 16 commits
  • 38 files changed
  • 7 contributors

Commits on Jul 19, 2024

  1. Configuration menu
    Copy the full SHA
    0e8d80d View commit details
    Browse the repository at this point in the history
  2. 🐛 Fix wrong links in docker_client.md (#613)

    I think the links anchors changed when we changed the docstring generation. It's not a big deal, we can fix it.
    gabrieldemarmiesse authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    e0d77a6 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. Configuration menu
    Copy the full SHA
    682ff91 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Configuration menu
    Copy the full SHA
    172e1cc View commit details
    Browse the repository at this point in the history
  2. Replace isort, black and flake8 with ruff (#617)

    [Ruff](https://docs.astral.sh/ruff/) has emerged as the most popular
    tool for linting, and covers the rules from flake8 among others. It also
    serves as an (almost) drop in replacement for black and isort.
    
    This PR replaces flake8, isort and black with ruff. 
    * There are some minor differences is how black and ruff formats the
    files, as seen in the files formatted in this PR
    * Ruff with `F`, `E` and `W` covers the rules by the existing flake8
    according to [these
    docs](https://docs.astral.sh/ruff/faq/#how-does-ruff-compare-to-flake8)
    * Updated pre-commit and github actions to also use Ruff
    einarwar authored Aug 5, 2024
    Configuration menu
    Copy the full SHA
    9874b40 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Configuration menu
    Copy the full SHA
    144fd12 View commit details
    Browse the repository at this point in the history
  2. Fix handling of 'podman pod create --share=...' (#620)

    Previously treated `Pod.create(share=[])` the same as not passing the
    `share` arg (not passing it to podman), but the podman default is to
    share `uts`, `ipc` and `net` namespaces. This means there's no way to
    specify that *no* namespaces should be shared.
    
    In addition, podman expects this list of namespaces to be passed as a
    single comma-separated arg, e.g. `--share uts,ipc`, not in the form
    `--share uts --share ipc` (only the last is taken in this case). This
    means there's another bug where the use of the internal
    `Command.add_args_iterable()` helper method meant only one shared
    namespace could be specified.
    
    It seems possible there could be other related bugs to do with the
    format of lists on the CLI...
    LewisGaul authored Aug 6, 2024
    Configuration menu
    Copy the full SHA
    338feb5 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Configuration menu
    Copy the full SHA
    69b2ac3 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Fix "Render docs" CI job (#628)

    Hopefully fixing two issues that have started being hit in the "Render
    docs" CI job:
    * `podman pod create` failing with "initializing source
    docker://k8s.gcr.io/pause:3.5: Requesting bear token: invalid status
    code from registry 404 (Not Found)", reported at
    #625 (comment)
    and seen in other PRs too.
    * Fixed by updating podman in the CI, since doc generation involves
    running podman commands.
    * `ModuleNotFoundError: No module named 'griffe.collections'` reported
    at
    #625 (comment)
    and seen in other PRs too.
    * Fixed by updating doc package dependencies and pinning a couple more
    indirect dependencies (I think the lack of pinning `griffe` while
    pinning to an older version of `mkdocstrings-python` was the
    problem...).
    LewisGaul authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9da040b View commit details
    Browse the repository at this point in the history
  2. Drop support for pydantic v1 (#630)

    Fixes #594
    LewisGaul authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    1a7f3ea View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cfd6920 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7bd00cb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6ac7b6f View commit details
    Browse the repository at this point in the history
  6. Added missing docstrings for network functions (#631)

    They should now show up in the docs.
    stock90975 authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    f58af9e View commit details
    Browse the repository at this point in the history
  7. Add "network exists" command (#632)

    Podman has support for a "network exists" command which checks if a
    network exists. This adds support for that command, although it does so
    by way of network inspect for compatibility with Docker, which does not
    have a standalone `network exists` command.
    
    Closes #618
    
    ---------
    
    Co-authored-by: Gabriel de Marmiesse <[email protected]>
    eclark0426 and gabrieldemarmiesse authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    4a518a5 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Configuration menu
    Copy the full SHA
    86a5c8d View commit details
    Browse the repository at this point in the history
Loading