Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow signatures to be updated without being open initially #1220

Conversation

TheAngryByrd
Copy link
Member

@TheAngryByrd TheAngryByrd commented Jan 14, 2024

Previous we were only getting checks for open files in codefixes, this fixes that. So, in the case of UpdateValueInSignatureFile, it wouldn't present the Codefix without the corresponding signature file already open.

Now it will, but it doesn't seem to save the file after the codefix. I think we can fix that later though.

update-signature-file.mp4

@TheAngryByrd TheAngryByrd force-pushed the update-sig-without-signature-needing-to-be-open branch from 3534a85 to 2c275db Compare January 14, 2024 16:55
@baronfel
Copy link
Contributor

This is great! As for the codefix-not-saving part, I think that's the status quo, right? Any edits get applied to their document, but the user must still save the file. I wonder if we need something in Ionide proper as some kind of post-apply-codefix handler to ask the editor to save the effected files.

@TheAngryByrd
Copy link
Member Author

As for the codefix-not-saving part, I think that's the status quo, right? Any edits get applied to their document, but the user must still save the file. I wonder if we need something in Ionide proper as some kind of post-apply-codefix handler to ask the editor to save the effected files.

Yeah probably normal. But I know we're gonna get complaints so at least wanted to mention it.

@TheAngryByrd TheAngryByrd merged commit 9494bbf into ionide:main Jan 14, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants