Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set flakiness threshold on a per-task/test in ci.yaml #151195

Closed
jtmcdole opened this issue Jul 2, 2024 · 2 comments · Fixed by flutter/cocoon#3803
Closed

Ability to set flakiness threshold on a per-task/test in ci.yaml #151195

jtmcdole opened this issue Jul 2, 2024 · 2 comments · Fixed by flutter/cocoon#3803
Assignees
Labels
team-infra Owned by Infrastructure team

Comments

@jtmcdole
Copy link
Contributor

jtmcdole commented Jul 2, 2024

Summary:

Suggestion:

Add flakiness_threshold as optional to ci.yaml and check it here:
https://github.com/flutter/cocoon/blob/b20de7e2b65d5dd61618f0f4303c5b19eb541266/app_dart/lib/src/request_handlers/file_flaky_issue_and_pr.dart#L101-L104

Then we can tune our pain-threshold for specific tests.

@jtmcdole jtmcdole self-assigned this Jul 2, 2024
@jtmcdole jtmcdole added the team-infra Owned by Infrastructure team label Jul 2, 2024
@christopherfujino
Copy link
Member

This seems reasonable

jtmcdole added a commit to jtmcdole/cocoon that referenced this issue Jul 3, 2024
Targets should be able to define higher or lower threshold limits.

Fixes flutter/flutter#151195
jtmcdole added a commit to jtmcdole/cocoon that referenced this issue Jul 10, 2024
Targets should be able to define higher or lower threshold limits.

Fixes flutter/flutter#151195
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-infra Owned by Infrastructure team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants