Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove FluidFile #73

Open
weefuzzy opened this issue Jan 17, 2022 · 3 comments
Open

remove FluidFile #73

weefuzzy opened this issue Jan 17, 2022 · 3 comments
Assignees
@weefuzzy

Comments

@weefuzzy
Copy link
Member

weefuzzy commented Jan 17, 2022 •
edited
Loading

include/data/FluidFile.hpp is unused, and not especially nice. It should be removed.
@weefuzzy weefuzzy self-assigned this Jan 17, 2022
@tremblap
Copy link
Member

I have vague memories it was there to remove the HISSTools::IAudioFile dependency in the tests and examples, or was it another dependency it was there to remove?

@weefuzzy
Copy link
Member Author

It certainly wasn't that: it has code for reading / writing JSON files, but this isn't the code that's actually used in practice.

@tremblap
Copy link
Member

Enjoy the pruning then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weefuzzy weefuzzy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tremblap @weefuzzy