{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":191571023,"defaultBranch":"master","name":"AbstractAlgebra.jl","ownerLogin":"fingolfin","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2019-06-12T12:55:44.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/241512?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1726777304.0","currentOid":""},"activityList":{"items":[{"before":"d36b019e70513132fa67a38ee89158c44ff03571","after":"78d9f59c8871e46d97f1431298d14c14f4a37969","ref":"refs/heads/mh/inbounds-is_zero_row","pushedAt":"2024-09-19T20:55:52.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"Optimize is_zero_row/_column\n\n... by avoiding redundant bounds checks.\n\nAlso change the methods as well as that one for is_zero_entry to\napply to Julia matrices, too.","shortMessageHtmlLink":"Optimize is_zero_row/_column"}},{"before":null,"after":"d36b019e70513132fa67a38ee89158c44ff03571","ref":"refs/heads/mh/inbounds-is_zero_row","pushedAt":"2024-09-19T20:21:44.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"Optimize is_zero_row/_column\n\n... by avoiding redundant bounds checks.\n\nAlso remove redundant is_zero_row method for Julia matrices -- the generic one is just as efficient","shortMessageHtmlLink":"Optimize is_zero_row/_column"}},{"before":"9597e42e8cf0c40bb54b261cf3acc3af5aaf3b01","after":"7c30de793a98fc805a2af1c754490f820591df45","ref":"refs/heads/mh/addmul","pushedAt":"2024-09-19T14:09:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"Make addmul! fully generic, add docstrings\n\nNow we can e.g. use addmul! on 3 or 4 ZZMatrix instances and get an\nefficient result.\n\nUse this to get rid of some now redundant `addmul!` methods.\n\nAlso remove some redundant `add!` methods and add some `sub!` methods.","shortMessageHtmlLink":"Make addmul! fully generic, add docstrings"}},{"before":null,"after":"9597e42e8cf0c40bb54b261cf3acc3af5aaf3b01","ref":"refs/heads/mh/addmul","pushedAt":"2024-09-19T14:08:00.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"Make addmul! fully generic, add docstrings\n\nNow we can e.g. use addmul! on 3 or 4 ZZMatrix instances and get an\nefficient result.\n\nUse this to get rid of some now redundant `addmul!` methods.\n\nAlso remove some redundant `add!` methods and add some `sub!` methods.","shortMessageHtmlLink":"Make addmul! fully generic, add docstrings"}},{"before":"6a9d2cdc98d9c7351d16aa9c760f63b020faee7b","after":"53a62ae6df396139b5c9643774d090246d90492e","ref":"refs/heads/mh/fix-ispower_moduli","pushedAt":"2024-08-21T09:26:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"lgoettgens","name":"Lars Göttgens","path":"/lgoettgens","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26390525?s=80&v=4"},"commit":{"message":"Merge branch 'master' into mh/fix-ispower_moduli","shortMessageHtmlLink":"Merge branch 'master' into mh/fix-ispower_moduli"}},{"before":"cf1b84ed8d7e2efc21b7c0d72ecffae0fa5b1714","after":"6a9d2cdc98d9c7351d16aa9c760f63b020faee7b","ref":"refs/heads/mh/fix-ispower_moduli","pushedAt":"2024-08-20T13:28:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"Merge aux tables for ispower_moduli into one","shortMessageHtmlLink":"Merge aux tables for ispower_moduli into one"}},{"before":"aa58e86f336e88049ad1cee0451a81c27f89c83f","after":"cf1b84ed8d7e2efc21b7c0d72ecffae0fa5b1714","ref":"refs/heads/mh/fix-ispower_moduli","pushedAt":"2024-08-20T13:24:56.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"Fix and document AbstractAlgebra.ispower_moduli\n\nThe prior code did not do any wrong computations, it just\nneglected to actually use the third set of moduli/residues\ntables for the prime 7 due to a typo, which this patch fixes.\n\nThis patch also cleans up the handling of even 'a' and adds\na bunch of comments to explain what is going on.\n\nFinally, it also extends the check mod 8 to even n. The prior\ncheck here was a bit hackish in that it hardcoded the assumption\nthat moduli5[1] is 8.","shortMessageHtmlLink":"Fix and document AbstractAlgebra.ispower_moduli"}},{"before":"b73f7aeea4398da13afbdadb15fbea01b7509858","after":"aa58e86f336e88049ad1cee0451a81c27f89c83f","ref":"refs/heads/mh/fix-ispower_moduli","pushedAt":"2024-08-20T13:19:11.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"Fix and document AbstractAlgebra.ispower_moduli\n\nThe prior code did not do any wrong computations, it just\nneglected to actually use the third set of moduli/residues\ntables for the prime 7 due to a typo, which this patch fixes.\n\nThis patch also cleans up the handling of even 'a' and adds\na bunch of comments to explain what is going on.\n\nFinally, it also extends the check mod 8 to even n. The prior\ncheck here was a bit hackish in that it hardcoded the assumption\nthat moduli5[1] is 8.","shortMessageHtmlLink":"Fix and document AbstractAlgebra.ispower_moduli"}},{"before":"638d2a3ca8ad3cf1a0639fda4774ec5b6bf0e79f","after":"b73f7aeea4398da13afbdadb15fbea01b7509858","ref":"refs/heads/mh/fix-ispower_moduli","pushedAt":"2024-08-20T13:16:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"Fix and document AbstractAlgebra.ispower_moduli\n\nThe prior code did not do any wrong computations, it just\nneglected to actually use the third set of moduli/residues\ntables for the prime 7 due to a typo, which this patch fixes.\n\nThis patch also cleans up the handling of even 'a' and adds\na bunch of comments to explain what is going on.\n\nFinally, it also extends the check mod 8 to even n. The prior\ncheck here was a bit hackish in that it hardcoded the assumption\nthat moduli5[1] is 8.","shortMessageHtmlLink":"Fix and document AbstractAlgebra.ispower_moduli"}},{"before":"67b5459741cb2d8e5e38704dd6c5b5cb90f6fecc","after":"638d2a3ca8ad3cf1a0639fda4774ec5b6bf0e79f","ref":"refs/heads/mh/fix-ispower_moduli","pushedAt":"2024-08-20T13:07:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"Fix and document AbstractAlgebra.ispower_moduli\n\nThe prior code did not do any wrong computations, it just\nneglected to actually use the third set of moduli/residues\ntables for the prime 7 due to a typo, which this patch fixes.\n\nThis patch also cleans up the handling of even 'a' and adds\na bunch of comments to explain what is going on.\n\nFinally, it also extends the check mod 8 to even n. The prior\ncheck here was a bit hackish in that it hardcoded the assumption\nthat moduli5[1] is 8.","shortMessageHtmlLink":"Fix and document AbstractAlgebra.ispower_moduli"}},{"before":"689f0cba0388bfeb4e67f39542768646682b9792","after":"67b5459741cb2d8e5e38704dd6c5b5cb90f6fecc","ref":"refs/heads/mh/fix-ispower_moduli","pushedAt":"2024-08-20T13:07:00.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"Fix and document AbstractAlgebra.ispower_moduli\n\nThe prior code did not do any wrong computations, it just\nneglected to actually use the third set of moduli/residues\ntables for the prime 7 due to a typo, which this patch fixes.\n\nThis patch also cleans up the handling of even 'a' and adds\na bunch of comments to explain what is going on.\n\nFinally, it also extends the check mod 8 to even n. The prior\ncheck here was a bit hackish in that it hardcoded the assumption\nthat moduli5[1] is 8.","shortMessageHtmlLink":"Fix and document AbstractAlgebra.ispower_moduli"}},{"before":"e533978c431af7f1eebd9b37805bf852f9f49473","after":"689f0cba0388bfeb4e67f39542768646682b9792","ref":"refs/heads/mh/fix-ispower_moduli","pushedAt":"2024-08-20T09:34:13.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"Fix and document AbstractAlgebra.ispower_moduli\n\nThe prior code did not do any wrong computations, it just\nneglected to actually use the third set of moduli/residues\ntables for the prime 7 due to a typo, which this patch fixes.\n\nThis patch also cleans up the handling of even 'a' and adds\na bunch of comments to explain what is going on.","shortMessageHtmlLink":"Fix and document AbstractAlgebra.ispower_moduli"}},{"before":null,"after":"e533978c431af7f1eebd9b37805bf852f9f49473","ref":"refs/heads/mh/fix-ispower_moduli","pushedAt":"2024-08-19T08:46:43.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"Fix and document AbstractAlgebra.ispower_moduli\n\nThe prior code did not do any wrong computations, it just\nneglected to actually use the third set of moduli/residues\ntables for the prime 7 due to a typo, which this patch fixes.\n\nThis patch also cleans up the handling of even 'a' and adds\na bunch of comments to explain what is going on.","shortMessageHtmlLink":"Fix and document AbstractAlgebra.ispower_moduli"}},{"before":"ff16e2459a17f528dc944b63535b066cd0b51f0f","after":null,"ref":"refs/heads/mh/rm-invalidations-ci","pushedAt":"2024-07-26T18:56:20.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"}},{"before":null,"after":"ff16e2459a17f528dc944b63535b066cd0b51f0f","ref":"refs/heads/mh/rm-invalidations-ci","pushedAt":"2024-07-26T14:45:13.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"CI: stop testing for invalidations\n\nThis test is unreliable, often misleading, and we mostly ignore it anyway.\n\nSee also https://github.com/julia-actions/julia-invalidations/issues/19","shortMessageHtmlLink":"CI: stop testing for invalidations"}},{"before":"b0f938dd9df4887a6cf3ce7d3e982436e99b285a","after":null,"ref":"refs/heads/mh/ring-interface-example","pushedAt":"2024-07-18T12:10:56.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"}},{"before":"eda941057ed5ad0a986d36fc4989560d7d0fea85","after":null,"ref":"refs/heads/mh/evaluate-fracelem","pushedAt":"2024-07-18T12:10:56.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"}},{"before":null,"after":"eda941057ed5ad0a986d36fc4989560d7d0fea85","ref":"refs/heads/mh/evaluate-fracelem","pushedAt":"2024-07-17T12:19:33.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"Enhance evaluate for FracElem to support 3-arg variants\n\n... which MPolyRing and UniversalPolyRing use to allow specifying\na list of variable indices followed by a list of values.","shortMessageHtmlLink":"Enhance evaluate for FracElem to support 3-arg variants"}},{"before":null,"after":"b0f938dd9df4887a6cf3ce7d3e982436e99b285a","ref":"refs/heads/mh/ring-interface-example","pushedAt":"2024-07-17T11:43:18.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"docs: adjust ring interface example to current naming conventions","shortMessageHtmlLink":"docs: adjust ring interface example to current naming conventions"}},{"before":"abef015645f10d66db8d164694c8f86686aef251","after":null,"ref":"refs/heads/mh/default-addeq","pushedAt":"2024-07-10T13:02:08.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"}},{"before":"907b517dd96862ee91542e7d59801dc323f9478a","after":null,"ref":"refs/heads/mh/cleanup","pushedAt":"2024-07-10T13:02:08.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"}},{"before":"c5e121a406dfcabe0b6f1152979f55a3ca08eec8","after":null,"ref":"refs/heads/mh/check_parent_type","pushedAt":"2024-07-10T13:02:08.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"}},{"before":"d9f9b955b62d35440dba64ed7a2ed9fc6db4f84a","after":"907b517dd96862ee91542e7d59801dc323f9478a","ref":"refs/heads/mh/cleanup","pushedAt":"2024-07-08T10:13:26.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"Some trivial cleanup\n\n- delay computation of a gcd until it really is needed in `addeq!`\n  and `add!` methods for `FracElem` (thus matching what the `+` and `-`\n  methods already are doing)\n- reorder some code in `*` and `mul!` methods for `TotFrac` (thus matching\n  the order in the `+`, `add!` etc. methods)","shortMessageHtmlLink":"Some trivial cleanup"}},{"before":"e63c085f0c8a65ec806bae83f2222fe73c3e2df6","after":"abef015645f10d66db8d164694c8f86686aef251","ref":"refs/heads/mh/default-addeq","pushedAt":"2024-07-05T21:17:58.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"Change default methods for addeq! to delegate to add!","shortMessageHtmlLink":"Change default methods for addeq! to delegate to add!"}},{"before":null,"after":"d9f9b955b62d35440dba64ed7a2ed9fc6db4f84a","ref":"refs/heads/mh/cleanup","pushedAt":"2024-07-05T21:15:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"Some trivial cleanup\n\n- delete computation of a gcd until it really is needed in `addeq!`\n  and `add!` methods for `FracElem` (thus matching what the `+` and `-`\n  methods already are doing)\n- reorder some code in `*` and `mul!` methods for `TotFrac` (thus matching\n  the order in the `+`, `add!` etc. methods)","shortMessageHtmlLink":"Some trivial cleanup"}},{"before":"bb51ad2d2f94da926502a1c363a5008202672624","after":"e63c085f0c8a65ec806bae83f2222fe73c3e2df6","ref":"refs/heads/mh/default-addeq","pushedAt":"2024-07-05T21:05:56.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"Change default methods for addeq! to delegate to add!","shortMessageHtmlLink":"Change default methods for addeq! to delegate to add!"}},{"before":null,"after":"bb51ad2d2f94da926502a1c363a5008202672624","ref":"refs/heads/mh/default-addeq","pushedAt":"2024-07-05T20:55:05.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"Add default implementation for addeq! delegating to add!","shortMessageHtmlLink":"Add default implementation for addeq! delegating to add!"}},{"before":null,"after":"c5e121a406dfcabe0b6f1152979f55a3ca08eec8","ref":"refs/heads/mh/check_parent_type","pushedAt":"2024-07-04T15:39:17.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"Revise check_parent for ResElem and ResFieldElem\n\nAlso remove check_parent_type.\n\nPreviously, we allowed binary operations involving two ResElem\ninstances of *different type*, with the type of the result\ndepending on the argument order. For example, this:\n\n    julia> using Nemo\n\n    julia> R = quo(ZZ, 2)[1]\n    Integers modulo 2\n\n    julia> S = Nemo.AbstractAlgebra.EuclideanRingResidueRing{UInt}(UInt(2))\n    Residue ring of integers modulo 2\n\n    julia> typeof(R)\n    zzModRing\n\n    julia> typeof(S)\n    EuclideanRingResidueRing{UInt64}\n\n    julia> S(1) + R(1)\n    0\n\n    julia> typeof(S(1) + R(1))\n    EuclideanRingResidueRingElem{UInt64}\n\n    julia> typeof(R(1) + S(1))\n    zzModRingElem\n\nBut this seems questionable at best. I think we are better of\nforbidding this -- which this PR effectively does.","shortMessageHtmlLink":"Revise check_parent for ResElem and ResFieldElem"}},{"before":"ae0dd1eddc5a3a963c2be49d6fa1f717f852e70a","after":null,"ref":"refs/heads/mh/CI","pushedAt":"2024-07-02T13:36:22.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"}},{"before":null,"after":"ae0dd1eddc5a3a963c2be49d6fa1f717f852e70a","ref":"refs/heads/mh/CI","pushedAt":"2024-07-02T12:26:27.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fingolfin","name":"Max Horn","path":"/fingolfin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/241512?s=80&v=4"},"commit":{"message":"CI: update julia-actions/cache to v2","shortMessageHtmlLink":"CI: update julia-actions/cache to v2"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEu0_7YQA","startCursor":null,"endCursor":null}},"title":"Activity · fingolfin/AbstractAlgebra.jl"}