-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deps: bumps ws version which patches a security vulnerability #45147
Closed
pranshuchittora
wants to merge
1
commit into
facebook:main
from
pranshuchittora:pranshuchittora/deps/bump-ws-sec-vul
Closed
Deps: bumps ws version which patches a security vulnerability #45147
pranshuchittora
wants to merge
1
commit into
facebook:main
from
pranshuchittora:pranshuchittora/deps/bump-ws-sec-vul
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jun 24, 2024
facebook-github-bot
added
the
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
label
Jun 24, 2024
Base commit: 986cf18 |
@arushikesarwani94 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
approved these changes
Jun 24, 2024
The old version is still getting pulled into lock file? |
I believe that's because of
|
This was referenced Jun 25, 2024
Merged
FWIW, this is covered by #45130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #45108
https://github.com/websockets/ws/releases/tag/6.2.3
Changelog:
[INTERNAL] [SECURITY] - Fixes CVE-2024-37890
Test Plan:
NA
Thanks :)