-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dev container support #5
Conversation
SergioGasquez
commented
May 30, 2022
- Add devcontainer support for:
- VS Code Dev Containers
- Gitpod
- GitHub Codespaces
- When using dev containers:
- Wokwi support
- Web flasher support
- Readme with instructions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! LGTM!
I did have a question about the two new shell scripts, are they needed for use in Rust projects like this one? Seems like the only thing that needs to be set is WOKWI_HOST
, then it's possible to use web-flash or wokwi-server as a cargo runner? Just a thought! By no means something to stop this being merged :).
Thanks for the quick review! The main purpose of the scripts is to make VS tasks less complex and, when using Wokwi in Gitpod/GH Codespaces, remove the need to export That being said, we could maybe move the complexity away from the scripts into wokwi-server and |
Thank you for this Sergio, great work! I would personally like to see the scripts either moved into a |
I moved the scripts into a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes!