Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Collection Location to Available Collections List on Packaging screen (biospecimen) (September release) #741

Open
wyattks opened this issue Sep 26, 2023 · 11 comments
Assignees
Labels
Biospecimen Dashboard CCC Priority 1 Issues to be addressed in the current release Priority 2 Biospecimen Priority 2 issue Shipping Dashboard

Comments

@wyattks
Copy link
Collaborator

wyattks commented Sep 26, 2023

In the list for available collections on the packaging screen, add a column showing the Collection Location for the bag. This request is mainly for the research sites that have many collection locations and shipping locations.

For research sites, use the locations selected at the time of Specimen Link
For clinical sites, use the overall site.

Collection Loction to Available list.pptx

@wyattks
Copy link
Collaborator Author

wyattks commented Sep 26, 2023

Alternate idea was to add a filter for selecting the collection location and only showing the available collections for that selected location in the available collections box. Would also have an "All" choice to show all collections across the site. We felt it would be easier to add in a column for the Collection location instead of adding in a filter.

@wyattks wyattks added the Priority 2 Biospecimen Priority 2 issue label Sep 26, 2023
@wyattks
Copy link
Collaborator Author

wyattks commented May 23, 2024

August or September Release?

@wyattks wyattks changed the title Add Collection Location to Available Collections List on Packaging screen Add Collection Location to Available Collections List on Packaging screen (biospecimen) May 23, 2024
@erincschwartz erincschwartz changed the title Add Collection Location to Available Collections List on Packaging screen (biospecimen) Add Collection Location to Available Collections List on Packaging screen (biospecimen) (September release) May 28, 2024
@erincschwartz
Copy link
Collaborator

Upon further discussion, we would like to move forward with adding the filter vs adding a column with collection location.

@sonyekere sonyekere added the CCC Priority 1 Issues to be addressed in the current release label Sep 3, 2024
@amber-emmes
Copy link
Collaborator

Just to be clear, what are the concept ID flags which I would be looking for on these specimens in each case, and are the options to be made available in the collection location list the same as in "Choose your shipping location" or taken from somewhere else? If so, what would the list of collection locations be expected to be? Thanks!

@erincschwartz
Copy link
Collaborator

@amber-emmes As we just discussed, it makes more sense to add the Collection Location column (vs. adding a drop down). For Research collections, the collection locations are selected by site team members on the Specimen Link page. Any collections that are from the Clinical Collection setting, should have a collection location of "Clinical"

@amber-emmes
Copy link
Collaborator

Merged into dev and ready for review.

@wyattks
Copy link
Collaborator Author

wyattks commented Sep 18, 2024

Checked in Dev. Ready for Stage

@amber-emmes
Copy link
Collaborator

Please re-review this and test the box shipping process to ensure there are no issues. The previous fix to this introduced an issue in the shipping workflow which should now be resolved.

@wyattks
Copy link
Collaborator Author

wyattks commented Sep 20, 2024

Hi Amber, I tested a couple of scenarios on this. I was able to add a bag to a box but if I remove that bag from the box and try to add that same bag back into a box, I am unable to do so unless I go back to the home screen and then back into the shipping dashboard.

Also after removing a bag, sometimes the number of collections listed in the avaiable collections feild is reduced even when I haven't added those bags to a box.

@amber-emmes
Copy link
Collaborator

Looking into this, but while I do that, can you confirm whether or not this issue also exists in stage? It doesn't sound immediately related to my changes, so it seems worth double-checking if this is an existing issue.

@wyattks
Copy link
Collaborator Author

wyattks commented Sep 20, 2024

I'm not able to check this in the Stage environment. Most who can are traveling home today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Biospecimen Dashboard CCC Priority 1 Issues to be addressed in the current release Priority 2 Biospecimen Priority 2 issue Shipping Dashboard
Projects
Development

No branches or pull requests

4 participants