-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Mypy --strict
internally
#514
Comments
What do @encode/maintainers think of this? |
Would we do it only for the codebase or also for tests? The benefit of doing it for tests is that you get to asses what the experience would be like for a user in strict mode. |
I see you did both in your PR. I'm in favor of it 😁 |
Based on #524 I'd probably be somewhat against it - looks like extra noise & fluff from my perspective. |
+1 for tests I didn't type tests before I read this article https://sethmlarson.dev/blog/tests-arent-enough-case-study-after-adding-types-to-urllib3#type-your-tests which outlined the same benefit. |
I agree its quite a bit of noise.. another option would be to do it incrementally as files are changed? |
Are there particular changes in the PR that you would rather see addressed separately, @tomchristie?
2. is the most important for the purpose of the PR. Each correction means one less error showing up to the user in VS Code and the like. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
adding typing in anyio found a large number of type level bugs, I'm in favor of this change - so unmarking stale |
I'm okay with us doing this, or at least with us moving towards it incrementally. |
I think we probably want to turn on |
Yeah that sort of thing. |
See encode/httpx#2436 for how I think we should approach this. |
I think being compatible with mypy
--strict
benefits end users who are also using it, if #513 is merged then there isn't much work left to be compatible with strict mode.See also #512
The text was updated successfully, but these errors were encountered: