-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kafka integration] Provide a clear guidance for Kafka hosts #9260
base: main
Are you sure you want to change the base?
Conversation
🚀 Benchmarks reportTo see the full report comment with |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hello @kush-elastic - I've also updated the docs and the changelog. Is there a way to preview the docs & the Fleet UI if it renders fine? |
Hey @lucabelluccini, You can setup local stack using elastic-package and checkout how changes looks like in local kibana. |
/test |
Update template for README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the review comments @lucabelluccini .
We can then proceed
/test |
@lucabelluccini : You have to make the change just to README under _dev. And run elastic-packagae build. |
Yep, that's the Today I Learnt :) moment |
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
@lucabelluccini Can we please address the suggested changes by @ishleenk17, so that we can close this one? |
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
Co-authored-by: Ishleen Kaur <[email protected]>
Co-authored-by: Ishleen Kaur <[email protected]>
💔 Build Failed
Failed CI StepsHistory
|
Hello all, I would like to get suggestions on which would be the messaging we should promote (to replace the link to the Beats repo issue). To me it seems an implementation limitation. Removing the link we lose the background/context of the issue. Let me know how you would like to proceed. |
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
bump |
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
Bump |
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
Proposed commit message
In order for Kafka integration to work properly, a user must provide all broker hosts.
The description should help users
Checklist
Related issues