Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kafka integration] Provide a clear guidance for Kafka hosts #9260

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

lucabelluccini
Copy link
Contributor

@lucabelluccini lucabelluccini commented Mar 4, 2024

Proposed commit message

In order for Kafka integration to work properly, a user must provide all broker hosts.
The description should help users

Checklist

  • None applies to this PR

Related issues

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucabelluccini
Copy link
Contributor Author

Hello @kush-elastic - I've also updated the docs and the changelog. Is there a way to preview the docs & the Fleet UI if it renders fine?
Once done, I think we can merge.

@kush-elastic
Copy link
Collaborator

Hey @lucabelluccini,
You can test this by following the steps mentioned in the Developer guide.

You can setup local stack using elastic-package and checkout how changes looks like in local kibana.

@kush-elastic
Copy link
Collaborator

/test

Update template for README
@lucabelluccini
Copy link
Contributor Author

image image

Tested locally.
Learnt about the _dev for the README.md TIL.

As I am not usually contributing to integration, would it be possible for the maintainers to follow up with the version bump, merge & release?

Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the review comments @lucabelluccini .
We can then proceed

packages/kafka/manifest.yml Outdated Show resolved Hide resolved
packages/kafka/_dev/build/docs/README.md Outdated Show resolved Hide resolved
@ishleenk17
Copy link
Contributor

/test

@ishleenk17
Copy link
Contributor

Learnt about the _dev for the README.md TIL.

@lucabelluccini : You have to make the change just to README under _dev. And run elastic-packagae build.
The actual README will automatically get generated.

@lucabelluccini
Copy link
Contributor Author

Learnt about the _dev for the README.md TIL.

@lucabelluccini : You have to make the change just to README under _dev. And run elastic-packagae build. The actual README will automatically get generated.

Yep, that's the Today I Learnt :) moment

@botelastic
Copy link

botelastic bot commented May 8, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added Stalled and removed Stalled labels May 8, 2024
@devamanv
Copy link
Contributor

devamanv commented May 8, 2024

@lucabelluccini Can we please address the suggested changes by @ishleenk17, so that we can close this one?

@botelastic
Copy link

botelastic bot commented Jun 7, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jun 7, 2024
@botelastic botelastic bot removed the Stalled label Jun 10, 2024
@elasticmachine
Copy link

elasticmachine commented Jun 10, 2024

💔 Build Failed

Failed CI Steps

History

cc @lucabelluccini

@lucabelluccini
Copy link
Contributor Author

Hello all,

I would like to get suggestions on which would be the messaging we should promote (to replace the link to the Beats repo issue).

To me it seems an implementation limitation. Removing the link we lose the background/context of the issue.

Let me know how you would like to proceed.

@botelastic
Copy link

botelastic bot commented Jul 10, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jul 10, 2024
@lucabelluccini
Copy link
Contributor Author

bump

@botelastic botelastic bot removed the Stalled label Jul 12, 2024
@andrewkroh andrewkroh added the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Jul 19, 2024
@botelastic
Copy link

botelastic bot commented Aug 18, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Aug 18, 2024
@lucabelluccini
Copy link
Contributor Author

Bump

@botelastic botelastic bot removed the Stalled label Aug 19, 2024
@botelastic
Copy link

botelastic bot commented Sep 18, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:kafka Kafka Stalled Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants