Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[windows] Windows Defender Data stream overhaul to GA #11249

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[windows] Windows Defender Data stream overhaul to GA #11249

wants to merge 7 commits into from
+417 −520

Conversation

nicpenning
Copy link
Contributor

@nicpenning nicpenning commented Sep 25, 2024 •
edited
Loading

  • Enhancement

Proposed commit message

Overhaul Windows Defender data stream in the Windows integration to make it GA.

Added many ECS fields and removed un-needed fields/processors

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Screenshots

image

@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Integration:windows Windows labels Sep 25, 2024
@nicpenning nicpenning marked this pull request as ready for review September 25, 2024 22:25
@nicpenning nicpenning requested review from a team as code owners September 25, 2024 22:25
@nicpenning
Copy link
Contributor Author

Ready for review and tests.

@andrewkroh andrewkroh added the Team:Security-Windows Platform Security Windows Platform Team [elastic/sec-windows-platform] label Sep 25, 2024
@elasticmachine
Copy link

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane] label Sep 26, 2024
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@nicpenning
Copy link
Contributor Author

Made a few corrections. Please review and test now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana VihasMakwana is a code owner automatically assigned from elastic/elastic-agent-data-plane

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bugfix Pull request that fixes a bug issue Integration:windows Windows Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Security-Windows Platform Security Windows Platform Team [elastic/sec-windows-platform]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicpenning @elasticmachine @pierrehilbert @andrewkroh