cyberarkpas: improve efficiency of event.duration calculation #11011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
enhancement
Rather than allocating a char[] to iterate over, just iterate over the bytes of the string.
efd6
force-pushed
the
8307-cyberarkpas
branch
from
1e73ca1
to
37b29b1
Compare
🚀 Benchmarks reportTo see the full report comment with |
|
💚 Build Succeeded
cc @efd6 |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
kcreddy
approved these changes
Sep 13, 2024
|
Package cyberarkpas - 2.23.0 containing this change is available at https://epr.elastic.co/search?package=cyberarkpas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Rather than allocating a char[] to iterate over, just iterate over the bytes of the string.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
logs-cyberarkpas.auditScript for converting field to duration is slow #8307Screenshots