Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Add new section on Azure Functions hosting plans #10984

Merged
merged 4 commits into from
Sep 13, 2024
Merged

[DOCS] Add new section on Azure Functions hosting plans #10984

merged 4 commits into from
Sep 13, 2024

Conversation

alaudazzi
Copy link
Contributor

This PR adds a new section on the different hosting plans for Azure Functions metrics.

Closes #123

image

@alaudazzi alaudazzi added documentation Improvements or additions to documentation enhancement New feature or request docs labels Sep 3, 2024
@alaudazzi alaudazzi requested a review from a team as a code owner September 3, 2024 12:59
@andrewkroh andrewkroh added Integration:azure_functions Azure Functions Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Sep 3, 2024
muthu-mps
muthu-mps reviewed Sep 4, 2024
View reviewed changes
packages/azure_functions/_dev/build/docs/README.md Outdated
@@ -4,6 +4,11 @@ The Azure Functions integration allows you to monitor Azure Functions. Azure Fun

Use this integration to build web APIs, respond to database changes, process IoT streams, manage message queues, and more. Refer common [Azure Functions scenarios](https://learn.microsoft.com/en-us/azure/azure-functions/functions-scenarios?pivots=programming-language-csharp) for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The statement on Use this integration here is not appropriate. Probably we could address this change as well in the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @muthu-mps. What would be the suggested alternative?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are discussing about the Azure Functions and not the integration. Use Azure Functions instead of Use this integration would be the right fit.

@alaudazzi
Copy link
Contributor Author

Thank you, @muthu-mps I've integrated your feedback.

@muthu-mps
Copy link
Contributor

Thank you, @muthu-mps I've integrated your feedback.

Thanks @alaudazzi, You have to build and commit the docs/README file to fix the CI failure.

@alaudazzi
Copy link
Contributor Author

@zmoog
After I fix the CI failure, this PR is ready to be merged, unless you have additional feedback?

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@alaudazzi alaudazzi merged commit 40666e8 into elastic:main Sep 13, 2024
5 checks passed
alaudazzi added a commit that referenced this pull request Sep 13, 2024
@alaudazzi
Revert "[DOCS] Add new section on Azure Functions hosting plans (#10984…
d327258 
…)"

This reverts commit 40666e8.
@alaudazzi alaudazzi mentioned this pull request Sep 13, 2024
Merged
@elasticmachine
Copy link

Package azure - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

Assignees
No one assigned
Labels
docs documentation Improvements or additions to documentation enhancement New feature or request Integration:azure_functions Azure Functions Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Azure docs] Document hosting plans for Azure Functions metrics
5 participants
@alaudazzi @muthu-mps @elasticmachine @zmoog @andrewkroh