Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Enable wolfi images in CI except weekly builds #10969

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Sep 2, 2024

Proposed commit message

Enable Elastic Agent wolfi images for CI pipelines (PRs and daily jobs) except for weekly job.

Weekly pipeline:

ELASTIC_PACKAGE_DISABLE_ELASTIC_AGENT_WOLFI: "true"

Integrations serverless job would run also these wolfi docker images, but currently system tests are not executed in those builds:

test_package_in_serverless() {
local package=$1
TEST_OPTIONS="-v --report-format xUnit --report-output file"
echo "Test package: ${package}"
if ! ${ELASTIC_PACKAGE_BIN} test asset ${TEST_OPTIONS} ${COVERAGE_OPTIONS}; then
return 1
fi
if ! ${ELASTIC_PACKAGE_BIN} test static ${TEST_OPTIONS} ${COVERAGE_OPTIONS}; then
return 1
fi
# FIXME: adding test-coverage for serverless results in errors like this:
# Error: error running package pipeline tests: could not complete test run: error calculating pipeline coverage: error fetching pipeline stats for code coverage calculations: need exactly one ES node in stats response (got 4)
if ! ${ELASTIC_PACKAGE_BIN} test pipeline ${TEST_OPTIONS} ; then
return 1
fi
if ! ${ELASTIC_PACKAGE_BIN} test policy ${TEST_OPTIONS} ${COVERAGE_OPTIONS}; then
return 1
fi
echo ""
return 0
}

Author's Checklist

  • [ ]

Related issues

@mrodm mrodm self-assigned this Sep 2, 2024
@elasticmachine
Copy link

elasticmachine commented Sep 2, 2024

🚀 Benchmarks report

Package apache_tomcat 👍(5) 💚(1) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
connection_pool 6134.97 3816.79 -2318.18 (-37.79%) 💔
request 40000 27777.78 -12222.22 (-30.56%) 💔
thread_pool 10416.67 7407.41 -3009.26 (-28.89%) 💔

Package iptables 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 12345.68 10101.01 -2244.67 (-18.18%) 💔

Package stan 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 13157.89 10869.57 -2288.32 (-17.39%) 💔

Package system_audit 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
package 55555.56 41666.67 -13888.89 (-25%) 💔

Package ti_abusech 👍(0) 💚(0) 💔(4)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
malware 4484.3 2976.19 -1508.11 (-33.63%) 💔
malwarebazaar 3597.12 2717.39 -879.73 (-24.46%) 💔
threatfox 4761.9 3663 -1098.9 (-23.08%) 💔
url 5524.86 3861 -1663.86 (-30.12%) 💔

Package ti_eset 👍(0) 💚(5) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
botnet 7462.69 4950.5 -2512.19 (-33.66%) 💔
cc 11494.25 6250 -5244.25 (-45.62%) 💔

Package ti_misp 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
threat_attributes 3584.23 2512.56 -1071.67 (-29.9%) 💔

Package ti_otx 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
pulses_subscribed 2770.08 2197.8 -572.28 (-20.66%) 💔

Package ti_rapid7_threat_command 👍(0) 💚(0) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
alert 3401.36 1879.7 -1521.66 (-44.74%) 💔
ioc 2551.02 2040.82 -510.2 (-20%) 💔
vulnerability 4739.34 3649.64 -1089.7 (-22.99%) 💔

To see the full report comment with /test benchmark fullreport

@mrodm mrodm marked this pull request as ready for review September 3, 2024 16:39
@mrodm mrodm requested a review from a team as a code owner September 3, 2024 16:39
@elasticmachine
Copy link

elasticmachine commented Sep 5, 2024

💔 Build Failed

Failed CI Steps

History

cc @mrodm

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@mrodm mrodm merged commit 02914aa into elastic:main Sep 5, 2024
4 of 5 checks passed
@mrodm mrodm deleted the enable_wolfi_ea_images_ci branch September 5, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants