-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cisco_ios] Fix CISCO-IOS integration failed to parse logs coming from different application versions #10948
Conversation
…m different application versions
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
cc @aleksmaus |
Quality Gate passedIssues Measures |
Interesting, CI passed, so the |
hi @aleksmaus 👋 the differences that you mention for the community_id are indeed expected in 8.16.0 of Elasticsearch. The issue that captures the reason behind this change is the this one and essentially at this version of Elasticsearch we should get community ids for all supported protocol numbers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Package cisco_ios - 1.26.11 containing this change is available at https://epr.elastic.co/search?package=cisco_ios |
Proposed commit message
Fix CISCO-IOS integration failed to parse logs coming from different application versions.
This fixes yet another SDH coming from the user that provided yet another sample of logs that have a different format.
@pkoutsovasilis I noticed the difference in the expected output files between 8.15 and 8.16 version of the stack when running the pipeline tests. Few files for the community_id added when running pipeline test against 8.16:
Assuming this might be expected due to this change elastic/elasticsearch#111528. But wanted to get your 👀 on this in case if this is not expected from Elasticsearch side.
This PR includes the files regenerated with 8.15 at the moment. Will see if CI complains, then can regenerate against 8.16.
Checklist
changelog.yml
file.