Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cisco_ios] Fix CISCO-IOS integration failed to parse logs coming from different application versions #10948

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

aleksmaus
Copy link
Member

Proposed commit message

Fix CISCO-IOS integration failed to parse logs coming from different application versions.

This fixes yet another SDH coming from the user that provided yet another sample of logs that have a different format.

@pkoutsovasilis I noticed the difference in the expected output files between 8.15 and 8.16 version of the stack when running the pipeline tests. Few files for the community_id added when running pipeline test against 8.16:

            "network": {
                "community_id": "1:NCx7UOZoQUvxIB+uzqMmGnZTSzI=",

Assuming this might be expected due to this change elastic/elasticsearch#111528. But wanted to get your 👀 on this in case if this is not expected from Elasticsearch side.

This PR includes the files regenerated with 8.15 at the moment. Will see if CI complains, then can regenerate against 8.16.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@aleksmaus aleksmaus added Integration:cisco_ios Cisco IOS bugfix Pull request that fixes a bug issue Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Aug 30, 2024
@aleksmaus aleksmaus requested a review from a team as a code owner August 30, 2024 15:53
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@aleksmaus aleksmaus self-assigned this Aug 30, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @aleksmaus

@aleksmaus
Copy link
Member Author

Interesting, CI passed, so the community_id change/addition is not in the stack yet that is being used for CI tests here. I assume the integration tests will break once the elasticsearch change makes to CI.

@pkoutsovasilis
Copy link
Contributor

hi @aleksmaus 👋 the differences that you mention for the community_id are indeed expected in 8.16.0 of Elasticsearch. The issue that captures the reason behind this change is the this one and essentially at this version of Elasticsearch we should get community ids for all supported protocol numbers

Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aleksmaus aleksmaus merged commit f1c702b into elastic:main Aug 30, 2024
5 checks passed
@elasticmachine
Copy link

Package cisco_ios - 1.26.11 containing this change is available at https://epr.elastic.co/search?package=cisco_ios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:cisco_ios Cisco IOS Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants