Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jamf_protect: fix up dashboard filters #10927

Merged
merged 5 commits into from
Sep 1, 2024
Merged

jamf_protect: fix up dashboard filters #10927

merged 5 commits into from
Sep 1, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Aug 29, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added dashboard Relates to a Kibana dashboard bug, enhancement, or modification. bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] Integration:jamf_protect Jamf Protect labels Aug 29, 2024
@efd6 efd6 self-assigned this Aug 29, 2024
@elasticmachine
Copy link

elasticmachine commented Aug 29, 2024 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review August 29, 2024 04:45
@efd6 efd6 requested a review from a team as a code owner August 29, 2024 04:45
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@andrewkroh andrewkroh mentioned this pull request Aug 30, 2024
Merged
4 tasks
@efd6 efd6 requested a review from andrewkroh September 1, 2024 20:55
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
85.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@efd6 efd6 merged commit 0ec9b83 into elastic:main Sep 1, 2024
5 checks passed
@elasticmachine
Copy link

Package jamf_protect - 2.5.0 containing this change is available at https://epr.elastic.co/search?package=jamf_protect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@efd6 efd6

Labels
bugfix Pull request that fixes a bug issue dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:jamf_protect Jamf Protect Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Jamf Protect]: Dashboard queries not matching data in ES
3 participants
@efd6 @elasticmachine @andrewkroh