Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure] Application Gateway WAF: add event.reason #10007

Merged
merged 12 commits into from
Sep 25, 2024

Conversation

jH-
Copy link
Contributor

@jH- jH- commented May 29, 2024

Proposed commit message

Update the Azure Application Gateway pipeline to parse and include values from
`json.properties.details.data` into the ECS `event.reason` field.

This field provides action context by logging the specific data found in 
requests that matched a rule.

It excludes the field if `json.properties.details.message` contains values indicating 
missing headers or content were the reason to avoid unnecessary duplicate data.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.

How to test this PR locally

elastic-package stack up -v -d

# check that the updated integration version is included (https://localhost:8080/search?package=azure)

elastic-package test pipeline

elastic-package stack down

@jH- jH- requested review from a team as code owners May 29, 2024 13:52
Copy link

cla-checker-service bot commented May 29, 2024

💚 CLA has been signed

@jH-

This comment was marked as resolved.

@botelastic
Copy link

botelastic bot commented Jul 3, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jul 3, 2024
@jamiehynds jamiehynds added the Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] label Jul 3, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@botelastic botelastic bot removed the Stalled label Jul 3, 2024
@jamiehynds jamiehynds added enhancement New feature or request Stalled labels Jul 3, 2024
@botelastic botelastic bot removed the Stalled label Jul 3, 2024
@botelastic botelastic bot removed the Stalled label Jul 3, 2024
@kcreddy
Copy link
Contributor

kcreddy commented Jul 5, 2024

/test

@elasticmachine
Copy link

elasticmachine commented Jul 5, 2024

🚀 Benchmarks report

Package azure 👍(2) 💚(0) 💔(9)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
springcloudlogs 4098.36 3115.26 -983.1 (-23.99%) 💔
application_gateway 2967.36 1733.1 -1234.26 (-41.59%) 💔
auditlogs 1945.53 1526.72 -418.81 (-21.53%) 💔
eventhub 333333.33 250000 -83333.33 (-25%) 💔
firewall_logs 1420.45 1113.59 -306.86 (-21.6%) 💔
graphactivitylogs 1834.86 1451.38 -383.48 (-20.9%) 💔
identity_protection 4608.29 2724.8 -1883.49 (-40.87%) 💔
platformlogs 4950.5 2849 -2101.5 (-42.45%) 💔
provisioning 2898.55 2288.33 -610.22 (-21.05%) 💔

To see the full report comment with /test benchmark fullreport

packages/azure/changelog.yml Outdated Show resolved Hide resolved
@kcreddy kcreddy added Integration:azure Azure Logs and removed Integration:aws AWS labels Jul 5, 2024
@botelastic
Copy link

botelastic bot commented Aug 4, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@jH-
Copy link
Contributor Author

jH- commented Aug 14, 2024

@jH- , can you please sign the Contributor Agreement?

NOTE that this PR contains commits from two different email addresses so you may be need amend those commits to use the same email that you use to sign the CLA.

Signed.

@andrewkroh andrewkroh removed the needs CLA User must sign the Elastic Contributor License before review. label Aug 15, 2024
@andrewkroh andrewkroh added Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] needs CLA User must sign the Elastic Contributor License before review. and removed needs CLA User must sign the Elastic Contributor License before review. labels Aug 15, 2024
@kcreddy
Copy link
Contributor

kcreddy commented Aug 22, 2024

/test

@kcreddy
Copy link
Contributor

kcreddy commented Aug 22, 2024

@jH- could you please fix the merge conflicts?

@jH- jH- requested a review from a team as a code owner August 23, 2024 11:51
@kcreddy
Copy link
Contributor

kcreddy commented Aug 23, 2024

/test

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a bunch of changes outside of the packages/azure directory that need to undone. I think they were the result of merge issue.

Copy link
Contributor Author

@jH- jH- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted

[git-generate]
elastic-package -C packages/azure test pipeline -g -d application_gateway
@andrewkroh andrewkroh dismissed their stale review September 25, 2024 17:48

Merge issues were corrected. Changeset looks fine now.

@andrewkroh
Copy link
Member

/test

@andrewkroh andrewkroh enabled auto-merge (squash) September 25, 2024 17:53
@andrewkroh andrewkroh enabled auto-merge (squash) September 25, 2024 17:54
@andrewkroh andrewkroh enabled auto-merge (squash) September 25, 2024 17:56
@andrewkroh andrewkroh merged commit 9d46e70 into elastic:main Sep 25, 2024
3 checks passed
@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-vault-github-plugin-prod

Package azure - 1.17.0 containing this change is available at https://epr.elastic.co/search?package=azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:azure Azure Logs Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants