Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenJDK jdk_vector_double128, jdk_vector_int128, jdk_vector_long128 passed but failed #17185

Closed
pshipton opened this issue Apr 13, 2023 · 30 comments
Closed

OpenJDK jdk_vector_double128, jdk_vector_int128, jdk_vector_long128 passed but failed #17185

pshipton opened this issue Apr 13, 2023 · 30 comments
Assignees
@gita-omr
Labels
comp:jit test failure
Milestone
Java 22 (0.45)

Comments

@pshipton
Copy link
Member

pshipton commented Apr 13, 2023 •
edited
Loading

https://openj9-jenkins.osuosl.org/job/Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly/34/
win2012-x86-1
jdk_vector_double128_j9_0

22:52:21  Test results: passed: 1
22:52:25  Report written to F:\Users\jenkins\workspace\Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly\aqa-tests\TKG\output_16813510301933\jdk_vector_double128_j9_0\report\html\report.html
22:52:25  Results written to F:\Users\jenkins\workspace\Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly\aqa-tests\TKG\output_16813510301933\jdk_vector_double128_j9_0\work
22:52:25  grep #VECTOR API F:/Users/jenkins/workspace/Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly/aqa-tests/\TKG\output_16813510301933\jdk_vector_double128_j9_0/work/jdk/incubator/vector/Double128VectorTests.jtr
22:52:25  -----------------------------------
22:52:25  jdk_vector_double128_j9_0_FAILED

jdk_vector_int128_j9_0

22:54:50  Test results: passed: 1
22:54:59  Report written to F:\Users\jenkins\workspace\Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly\aqa-tests\TKG\output_16813510301933\jdk_vector_int128_j9_0\report\html\report.html
22:54:59  Results written to F:\Users\jenkins\workspace\Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly\aqa-tests\TKG\output_16813510301933\jdk_vector_int128_j9_0\work
22:54:59  grep #VECTOR API F:/Users/jenkins/workspace/Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly/aqa-tests/\TKG\output_16813510301933\jdk_vector_int128_j9_0/work/jdk/incubator/vector/Int128VectorTests.jtr
22:54:59  -----------------------------------
22:54:59  jdk_vector_int128_j9_0_FAILED

jdk_vector_long128_j9_0

23:03:22  Test results: passed: 1
23:03:32  Report written to F:\Users\jenkins\workspace\Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly\aqa-tests\TKG\output_16813510301933\jdk_vector_long128_j9_0\report\html\report.html
23:03:32  Results written to F:\Users\jenkins\workspace\Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly\aqa-tests\TKG\output_16813510301933\jdk_vector_long128_j9_0\work
23:03:32  grep #VECTOR API F:/Users/jenkins/workspace/Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly/aqa-tests/\TKG\output_16813510301933\jdk_vector_long128_j9_0/work/jdk/incubator/vector/Long128VectorTests.jtr
23:03:32  -----------------------------------
23:03:32  jdk_vector_long128_j9_0_FAILED

Changes from previous build
f9950fe...4a2643c
adoptium/aqa-tests@44ea825...4fd9cfa
@pshipton
Copy link
Member Author

@gita-omr @llxia fyi

@gita-omr
Copy link
Contributor

The tests check if vectorization happened by using grep. Vectorization was never enabled on x86. So I am actually wondering how this could work before… @BradleyWood

@llxia
Copy link
Contributor

llxia commented Apr 13, 2023

These tests passed in openjdk run, but we add the extra step grep #VECTOR API F:/Users/jenkins/workspace/Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly/aqa-tests/\TKG\output_16813510301933\jdk_vector_long128_j9_0/work/jdk/incubator/vector/Long128VectorTests.jtr. The failure is due to #VECTOR API cannot be found in jtr file.

@gita-omr
Copy link
Contributor

gita-omr commented Apr 14, 2023 •
edited
Loading

These tests passed in openjdk run, but we add the extra step grep #VECTOR API F:/Users/jenkins/workspace/Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly/aqa-tests/\TKG\output_16813510301933\jdk_vector_long128_j9_0/work/jdk/incubator/vector/Long128VectorTests.jtr. The failure is due to #VECTOR API cannot be found in jtr file.

I thought that step was there for a while. Was it added recently for some tests? @llxia I am just wondering how "VECTOR API" could be produced on x86 before.

@gita-omr
Copy link
Contributor

@r30shah fyi

@llxia
Copy link
Contributor

llxia commented Apr 14, 2023

Was it added recently for some tests?

No, there were no recent changes to these tests.

Also, ran jdk_vector_double128_j9_0 using one of the previously passed JDK:

Double128VectorTests.jtr file contains #VECTOR API :

lanxia@Lans-MacBook-Pro jdk_vector_double128_j9_0 % grep -R "#VECTOR API" .
./work/jdk/incubator/vector/Double128VectorTests.jtr:#VECTOR API: Scalarized using dabs in Double128VectorTests.ABSDouble128VectorTests(Ljava/util/function/IntFunction;)V at scorching
./work/jdk/incubator/vector/Double128VectorTests.jtr:#VECTOR API: Scalarized using dabs in Double128VectorTests.ABSDouble128VectorTests(Ljava/util/function/IntFunction;)V at scorching
./work/jdk/incubator/vector/Double128VectorTests.jtr:#VECTOR API: Scalarized using dabs in Double128VectorTests.ABSDouble128VectorTests(Ljava/util/function/IntFunction;)V at scorching
./work/jdk/incubator/vector/Double128VectorTests.jtr:#VECTOR API: Scalarized using dadd in Double128VectorTests.ADDDouble128VectorTests(Ljava/util/function/IntFunction;Ljava/util/function/IntFunction;)V at scorching
./work/jdk/incubator/vector/Double128VectorTests.jtr:#VECTOR API: Scalarized using dadd in Double128VectorTests.ADDDouble128VectorTests(Ljava/util/function/IntFunction;Ljava/util/function/IntFunction;)V at scorching
./work/jdk/incubator/vector/Double128VectorTests.jtr:#VECTOR API: Scalarized using dadd in Double128VectorTests.ADDDouble128VectorTests(Ljava/util/function/IntFunction;Ljava/util/function/IntFunction;)V at scorching
...

@r30shah
Copy link
Contributor

r30shah commented Apr 14, 2023

@gita-omr As @llxia provided the snippet from the jtr file, It is not actually checking Vectorized flag in verbose output. It is checkint #VECTOR_API. We did not enable vectorization on X but it should still do the scalarization right? Seems like we did not scalarize in this case.

@pshipton
Copy link
Member Author

pshipton commented Apr 26, 2023 •
edited
Loading

https://openj9-jenkins.osuosl.org/job/Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly/43
win2012-x86-1
jdk_vector_float128_j9_0

21:25:03  Test results: passed: 1
21:25:03  Report written to F:\Users\jenkins\workspace\Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly\aqa-tests\TKG\output_16824683515877\jdk_vector_float128_j9_0\report\html\report.html
21:25:03  Results written to F:\Users\jenkins\workspace\Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly\aqa-tests\TKG\output_16824683515877\jdk_vector_float128_j9_0\work
21:25:03  grep #VECTOR API F:/Users/jenkins/workspace/Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly/aqa-tests/\TKG\output_16824683515877\jdk_vector_float128_j9_0/work/jdk/incubator/vector/Float128VectorTests.jtr
21:25:03  -----------------------------------
21:25:03  jdk_vector_float128_j9_0_FAILED

@dipak-bagadiya dipak-bagadiya mentioned this issue Apr 27, 2023
Merged
@pshipton
Copy link
Member Author

pshipton commented May 3, 2023

https://openj9-jenkins.osuosl.org/job/Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly/48
win2012-x86-1
jdk_vector_double128_j9_0

22:40:35  Test results: passed: 1
22:40:48  Report written to F:\Users\jenkins\workspace\Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly\aqa-tests\TKG\output_16830776542076\jdk_vector_double128_j9_0\report\html\report.html
22:40:48  Results written to F:\Users\jenkins\workspace\Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly\aqa-tests\TKG\output_16830776542076\jdk_vector_double128_j9_0\work
22:40:48  grep #VECTOR API F:/Users/jenkins/workspace/Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly/aqa-tests/\TKG\output_16830776542076\jdk_vector_double128_j9_0/work/jdk/incubator/vector/Double128VectorTests.jtr
22:40:48  -----------------------------------
22:40:48  jdk_vector_double128_j9_0_FAILED

@pshipton
Copy link
Member Author

pshipton commented May 5, 2023

https://openj9-jenkins.osuosl.org/job/Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly/50
win2012-x86-1
jdk_vector_long128_j9_0

21:36:03  Test results: passed: 1
21:36:04  Report written to F:\Users\jenkins\workspace\Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly\aqa-tests\TKG\output_16832458487505\jdk_vector_long128_j9_0\report\html\report.html
21:36:04  Results written to F:\Users\jenkins\workspace\Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly\aqa-tests\TKG\output_16832458487505\jdk_vector_long128_j9_0\work
21:36:04  grep #VECTOR API F:/Users/jenkins/workspace/Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly/aqa-tests/\TKG\output_16832458487505\jdk_vector_long128_j9_0/work/jdk/incubator/vector/Long128VectorTests.jtr
21:36:04  -----------------------------------
21:36:04  jdk_vector_long128_j9_0_FAILED

@pshipton
Copy link
Member Author

pshipton commented May 9, 2023

https://openj9-jenkins.osuosl.org/job/Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly/52
https://openj9-jenkins.osuosl.org/computer/win2012-x86-1

jdk_vector_float128_j9_0

22:52:38  Test results: passed: 1
22:52:45  Report written to F:\Users\jenkins\workspace\Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly\aqa-tests\TKG\output_16835968164890\jdk_vector_float128_j9_0\report\html\report.html
22:52:45  Results written to F:\Users\jenkins\workspace\Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly\aqa-tests\TKG\output_16835968164890\jdk_vector_float128_j9_0\work
22:52:45  grep #VECTOR API F:/Users/jenkins/workspace/Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly/aqa-tests/\TKG\output_16835968164890\jdk_vector_float128_j9_0/work/jdk/incubator/vector/Float128VectorTests.jtr
22:52:45  -----------------------------------
22:52:45  jdk_vector_float128_j9_0_FAILED

jdk_vector_short128_j9_0

22:59:38  Test results: passed: 1
22:59:50  Report written to F:\Users\jenkins\workspace\Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly\aqa-tests\TKG\output_16835968164890\jdk_vector_short128_j9_0\report\html\report.html
22:59:50  Results written to F:\Users\jenkins\workspace\Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly\aqa-tests\TKG\output_16835968164890\jdk_vector_short128_j9_0\work
22:59:50  grep #VECTOR API F:/Users/jenkins/workspace/Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly/aqa-tests/\TKG\output_16835968164890\jdk_vector_short128_j9_0/work/jdk/incubator/vector/Short128VectorTests.jtr
22:59:50  -----------------------------------
22:59:50  jdk_vector_short128_j9_0_FAILED

@JasonFengJ9
Copy link
Member

OMR abuild https://openj9-jenkins.osuosl.org/job/Test_openjdk20_j9_sanity.openjdk_x86-64_windows_OMR/13/consoleFull

11:26:11  Test results: passed: 1
11:26:13  Report written to F:\Users\jenkins\workspace\Test_openjdk20_j9_sanity.openjdk_x86-64_windows_OMR\aqa-tests\TKG\output_1685369840815\jdk_vector_float128_j9_0\report\html\report.html
11:26:13  Results written to F:\Users\jenkins\workspace\Test_openjdk20_j9_sanity.openjdk_x86-64_windows_OMR\aqa-tests\TKG\output_1685369840815\jdk_vector_float128_j9_0\work
11:26:13  grep #VECTOR API F:/Users/jenkins/workspace/Test_openjdk20_j9_sanity.openjdk_x86-64_windows_OMR/aqa-tests/\TKG\output_1685369840815\jdk_vector_float128_j9_0/work/jdk/incubator/vector/Float128VectorTests.jtr
11:26:13  -----------------------------------
11:26:13  jdk_vector_float128_j9_0_FAILED

@0xdaryl
Copy link
Contributor

0xdaryl commented May 29, 2023

As JDK20 is now part of the OMR Acceptance build and this failure has appeared in the OMR Acceptance build the priority of resolving this should be higher so that it doesn't block promotion.

@gita-omr : it is not clear who owns the next step on this one, but can you assign please.

@gita-omr gita-omr self-assigned this May 31, 2023
@gita-omr
Copy link
Contributor

I can see that Scalarization happens randomly on these tests. Investigating.

@gita-omr
Copy link
Contributor

Seems that it only failed on Windows. Please update if you happen to see failures on other platforms.

@pshipton
Copy link
Member Author

FYI they still occur fairly frequently (on Windows), I just stopped reporting them.

@gita-omr
Copy link
Contributor

Interesting... so it does look like only Windows problem.

@0xdaryl
Copy link
Contributor

0xdaryl commented Jun 21, 2023

@gita-omr : any updates on this issue? It is presently targeted to 0.40 so we will need to make a determination on it soon.

@gita-omr
Copy link
Contributor

I think we should move it to the next release. This is incubator and it’s not a functional failure: test case passes but it’s not scalarized. The failure is very random and seem to happen exclusively on Windows. I actually suspect some environment issues since the same tests passes on Windows internally.

@0xdaryl
Copy link
Contributor

0xdaryl commented Jun 21, 2023

@pshipton : are you ok with deferring this? I know it is impacting the OMR Acceptance build which means you (personally) have to manually ignore the failures when they occur to promote the build.

@pshipton
Copy link
Member Author

Yes it's fine, just one of many.

@pshipton
Copy link
Member Author

pshipton commented Jun 28, 2023 •
edited
Loading

In OMR acceptance. Likely occurs on all platforms, but they aren't yet all completed.

https://openj9-jenkins.osuosl.org/job/Test_openjdk20_j9_sanity.openjdk_aarch64_linux_OMR/31
https://openj9-jenkins.osuosl.org/job/Test_openjdk20_j9_sanity.openjdk_aarch64_mac_OMR/30
https://openj9-jenkins.osuosl.org/job/Test_openjdk20_j9_sanity.openjdk_ppc64le_linux_OMR/31
https://openj9-jenkins.osuosl.org/job/Test_openjdk20_j9_sanity.openjdk_s390x_linux_OMR/31
https://openj9-jenkins.osuosl.org/job/Test_openjdk20_j9_sanity.openjdk_x86-64_mac_OMR/30
jdk_vector_float128_j9_0
jdk_vector_double128_j9_0
jdk_vector_int128_j9_0
jdk_vector_short128_j9_0
jdk_vector_byte128_j9_0
jdk_vector_long128_j9_0
jdk_vector_byte64_j9_0

@pshipton pshipton mentioned this issue Jun 28, 2023
Closed
@pshipton
Copy link
Member Author

The previous comment can be ignored as those failures aren't related to this issue. This issue does occur regularly in the builds, but I'm not going to report them all.

The latest being
https://openj9-jenkins.osuosl.org/job/Test_openjdk20_j9_sanity.openjdk_x86-64_windows_Nightly_testList_1/1

@JasonFengJ9
Copy link
Member

https://openj9-jenkins.osuosl.org/job/Test_openjdk21_j9_sanity.openjdk_x86-64_windows_OMR_testList_2/1/consoleFull

12:15:43  Test results: passed: 1
12:15:55  -----------------------------------
12:15:55  jdk_vector_double128_j9_0_FAILED

@JasonFengJ9
Copy link
Member

https://openj9-jenkins.osuosl.org/job/Test_openjdk21_j9_sanity.openjdk_x86-64_windows_Nightly_testList_0/17/consoleFull

22:47:46  Test results: passed: 1
22:48:03  Report written to F:\Users\jenkins\workspace\Test_openjdk21_j9_sanity.openjdk_x86-64_windows_Nightly_testList_0\aqa-tests\TKG\output_16899912347093\jdk_vector_float128_j9_0\report\html\report.html
22:48:03  Results written to F:\Users\jenkins\workspace\Test_openjdk21_j9_sanity.openjdk_x86-64_windows_Nightly_testList_0\aqa-tests\TKG\output_16899912347093\jdk_vector_float128_j9_0\work
22:48:03  grep #VECTOR API F:/Users/jenkins/workspace/Test_openjdk21_j9_sanity.openjdk_x86-64_windows_Nightly_testList_0/aqa-tests/\TKG\output_16899912347093\jdk_vector_float128_j9_0/work/jdk/incubator/vector/Float128VectorTests.jtr
22:48:03  -----------------------------------
22:48:03  jdk_vector_float128_j9_0_FAILED

@pshipton
Copy link
Member Author

Still happening.
https://openj9-jenkins.osuosl.org/job/Test_openjdk21_j9_sanity.openjdk_x86-64_windows_Nightly_testList_2/33/
jdk_vector_short128_j9_0

@gita-omr
Copy link
Contributor

I think it's a low priority since the test case produces correct result.

@pshipton pshipton modified the milestones: Java 21 (0.42), Java 22 Aug 30, 2023
@pshipton
Copy link
Member Author

Vector is still an incubator so I've moved it forward.

@JasonFengJ9
Copy link
Member

JDK21 x86-64_windows

[2023-09-01T22:55:24.276Z] Test results: passed: 1
[2023-09-01T22:55:26.856Z] Report written to F:\Users\jenkins\workspace\Test_openjdk21_j9_sanity.openjdk_x86-64_windows_Nightly_testList_1\aqa-tests\TKG\output_16936068757990\jdk_vector_float128_j9_0\report\html\report.html
[2023-09-01T22:55:26.856Z] Results written to F:\Users\jenkins\workspace\Test_openjdk21_j9_sanity.openjdk_x86-64_windows_Nightly_testList_1\aqa-tests\TKG\output_16936068757990\jdk_vector_float128_j9_0\work
[2023-09-01T22:55:26.856Z] grep #VECTOR API F:/Users/jenkins/workspace/Test_openjdk21_j9_sanity.openjdk_x86-64_windows_Nightly_testList_1/aqa-tests/\TKG\output_16936068757990\jdk_vector_float128_j9_0/work/jdk/incubator/vector/Float128VectorTests.jtr
[2023-09-01T22:55:26.856Z] -----------------------------------
[2023-09-01T22:55:26.856Z] jdk_vector_float128_j9_0_FAILED

@pshipton
Copy link
Member Author

pshipton commented Dec 5, 2023

This hasn't been seen for some time, closing assuming fixed.

@pshipton pshipton closed this as completed Dec 5, 2023
@pshipton pshipton mentioned this issue Jan 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gita-omr gita-omr

Labels
comp:jit test failure
Projects
None yet
Milestone
Java 22 (0.45)
Development

No branches or pull requests
6 participants
@0xdaryl @JasonFengJ9 @pshipton @llxia @r30shah @gita-omr