Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency convergence in 3.0.5 #5087

Closed
agavrilov76 opened this issue Jun 17, 2022 · 9 comments · Fixed by #5092
Closed

Dependency convergence in 3.0.5 #5087

agavrilov76 opened this issue Jun 17, 2022 · 9 comments · Fixed by #5092
Assignees
Milestone

Comments

@agavrilov76
Copy link

The enforcer plugin fails with the following error on 3.0.5 due dependency convergence for jakarta.inject:jakarta.inject-api

Warning:  
Dependency convergence error for jakarta.inject:jakarta.inject-api:2.0.1 paths to dependency are:
+-com.telenordigital.tdbase:tdbase-client:1.0-SNAPSHOT
  +-org.glassfish.jersey.core:jersey-client:3.0.5
    +-org.glassfish.jersey.core:jersey-common:3.0.5
      +-jakarta.inject:jakarta.inject-api:2.0.1
and
+-com.telenordigital.tdbase:tdbase-client:1.0-SNAPSHOT
  +-org.glassfish.jersey.core:jersey-client:3.0.5
    +-jakarta.inject:jakarta.inject-api:2.0.1
and
+-com.telenordigital.tdbase:tdbase-client:1.0-SNAPSHOT
  +-org.glassfish.jersey.inject:jersey-hk2:3.0.5
    +-org.glassfish.hk2:hk2-locator:3.0.3
      +-jakarta.inject:jakarta.inject-api:2.0.0
and
+-com.telenordigital.tdbase:tdbase-client:1.0-SNAPSHOT
  +-org.glassfish.jersey.inject:jersey-hk2:3.0.5
    +-org.glassfish.hk2:hk2-locator:3.0.3
      +-org.glassfish.hk2:hk2-api:3.0.3
        +-jakarta.inject:jakarta.inject-api:2.0.0
and
+-com.telenordigital.tdbase:tdbase-client:1.0-SNAPSHOT
  +-org.glassfish.jersey.inject:jersey-hk2:3.0.5
    +-org.glassfish.hk2:hk2-locator:3.0.3
      +-org.glassfish.hk2:hk2-utils:3.0.3
        +-jakarta.inject:jakarta.inject-api:2.0.0

Warning:  Rule 1: org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
@jansupol
Copy link
Contributor

Congratulations! You are the first to file an issue with 3.0.5. That was fast!

Jersey does seem to be using the enforcer plugin itself. Sounds like it should.

@jansupol
Copy link
Contributor

The workaround is of course to exclude the jakarta.inject:jakarta.inject-api dependency from org.glassfish.jersey.inject:jersey-hk2 for the time being.

@zUniQueX
Copy link
Contributor

Jersey does seem to be using the enforcer plugin itself. Sounds like it should.

I'd appreciate having DependencyConvergence enabled. I've recently experienced an issue with that in the Grizzly connector too.

Currently Jersey uses the maven-enforcer-plugin:3.0.0-M2 without the DependencyConvergence rule enabled. Please note, that the rule has some issues in the final 3.0.0 release (e.g. MENFORCER-394). If you plan to upgrade the enforcer plugin, enabling DependencyConvergence may have to wait.

@senivam senivam self-assigned this Jun 21, 2022
@senivam senivam added this to the 3.0.6 milestone Jul 25, 2022
@mraible
Copy link

mraible commented Jul 26, 2022

Is this fixed in #5092? If so, can this issue be closed and v3.0.6 released?

@senivam
Copy link
Contributor

senivam commented Jul 27, 2022

Hi @mraible, yes, the dependency convergence issue is fixed and merged. But in order to do a release, we have to collect more fixes/features. I think a release will happen soon but I cannot predict an exact date for now.

@bdemers
Copy link

bdemers commented Jul 27, 2022

I have a biased opinion, but getting a release out sooner would allow for Jersey support to be added back into Spring Boot v3 😁

@senivam
Copy link
Contributor

senivam commented Jul 27, 2022

@bdemers sure, but with all due efforts, it won't be possible till the next week.

@bdemers
Copy link

bdemers commented Jul 27, 2022

Awesome news! thanks @senivam!

@senivam
Copy link
Contributor

senivam commented Aug 5, 2022

@bdemers, @mraible - the 3.0.6 version is available in central sine today.

@senivam senivam closed this as completed Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants