Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Beta 1] ionRefresher on Android 4.3 (Galaxy S3) #909

Closed
mquadrat opened this issue Mar 26, 2014 · 9 comments
Closed

[Beta 1] ionRefresher on Android 4.3 (Galaxy S3) #909

mquadrat opened this issue Mar 26, 2014 · 9 comments
Milestone

Comments

@mquadrat
Copy link

Expected Behaviour: only the pull arrow is rotated when a pulling-text is set
Behaviour on Android 4.3 (Galaxy S3): the pulling-text is rotated, too

I tried to capture it on video (bad quality, but you get the idea)

https://onedrive.live.com/redir?resid=4AE1BFC2CB37CE08!3837&authkey=!AM0cfNs5SXMG0fE&ithint=video,.mp4

@adamdbradley
Copy link
Contributor

Strange. Thanks for the video!

@adamdbradley adamdbradley self-assigned this Mar 26, 2014
@adamdbradley adamdbradley added this to the 1.0.0-beta.2 milestone Mar 26, 2014
@ajoslin
Copy link
Contributor

ajoslin commented Mar 26, 2014

I think we need to make the text inside of refresher be display: block, so it's on a separate line from the icon. There is already a weird problem at the moment where the text appears next to the icon at first.

ajoslin added a commit that referenced this issue Mar 26, 2014
@ajoslin
Copy link
Contributor

ajoslin commented Mar 26, 2014

I'm experiencing this in Safari too actually. list-fit.html (latest Chrome has a font bug that prevents PTR from being accurately tested.

It is still a CSS bug though; it's my fault for reusing the icon CSS classes when I added text capability to pull to refresh I think.

@ajoslin
Copy link
Contributor

ajoslin commented Mar 27, 2014

Fixed! thanks.

@mlynch
Copy link
Contributor

mlynch commented Mar 27, 2014

Does this fix that one issue on iOS as well? (there was a separate issue out for it)

On Mar 26, 2014, at 10:29 PM, Andy Joslin [email protected] wrote:

Closed #909 via 5c893ab.


Reply to this email directly or view it on GitHub.

@mlynch
Copy link
Contributor

mlynch commented Mar 27, 2014

#758

@mquadrat
Copy link
Author

Is the fix supposed to be in the current nighlty? If yes, then it is not working. The text still spins after the refresh has completed and it scrolls out of view. The arrow does look a bit weird, too.

https://onedrive.live.com/redir?resid=4AE1BFC2CB37CE08!3838&authkey=!ALkTW3gXJ3HT7Cw&ithint=video%2c.mp4

@ajoslin
Copy link
Contributor

ajoslin commented Mar 27, 2014

Hi @mquadrat,

Woops! I pushed last night but had a broken unit test, so it never pushed out the build.

It should be good now.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants