Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back button on popup show not disabled in android #1222

Closed
LeleDev opened this issue Apr 29, 2014 · 5 comments
Closed

Back button on popup show not disabled in android #1222

LeleDev opened this issue Apr 29, 2014 · 5 comments

Comments

@LeleDev
Copy link

LeleDev commented Apr 29, 2014

When a popup is shown, the user can still navigate back through the underlying views using the physical back button, on Android. I think that this behaviour can lead to many unpredictable states and issues. Could you please block the back button while a popup is visibile?

Thank you in andvance

@ajoslin
Copy link
Contributor

ajoslin commented Apr 29, 2014

We'll make the back button close the popup instead. Thanks for the issue!

@ajoslin ajoslin self-assigned this Apr 29, 2014
@LeleDev
Copy link
Author

LeleDev commented Apr 29, 2014

Thank you!

@gouegd
Copy link

gouegd commented May 1, 2014

Similarly the hardware back button also navigates back while the loading overlay (from $ionicLoading) is displayed.
Personally I avoid this by making the back button close the loading (I use promises to know it's been closed or not), but in some cases it could be better to just ignore the back button.

Ideally I think there'd be a sensible default (no action ?), and the possibility the add one's own callback.

What do you think ?

@LeleDev
Copy link
Author

LeleDev commented May 1, 2014

@gouegd , nice point, I totally agree! It would be wonderful if we could disable the back button when the loading overlay is visible!!

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants