Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BinaryFormatter error when clicking "Add Tab" command for TabControl in DemoConsole application #11607

Closed
Philip-Wang01 opened this issue Jun 28, 2024 · 4 comments
Closed

BinaryFormatter error when clicking "Add Tab" command for TabControl in DemoConsole application #11607

Philip-Wang01 opened this issue Jun 28, 2024 · 4 comments
Assignees
@LeafShi1
Labels
area-Serialization-BinaryFormatter-FeatureWork Feature work under the general area of BinaryFormatter related serialization 💥 regression-preview Regression from a preview release
Milestone
9.0 RC1

Comments

@Philip-Wang01
Copy link
Contributor

.NET version

.NET 9.0: Main branch of WinForms repo (.NET 9.0.0-preview.7.24326.3)

Did it work in .NET Framework?

Yes

Did it work in any of the earlier releases of .NET Core or .NET 5+?

Yes, this is a regression issue. Not repro on .NET 9.0.0-preview.6.24305.2

Issue description

In DemoConsole test app of Winforms repo, BinaryFormatter error when clicking "Add Tab" command for TabControl.

image

testaddtab.mp4

Steps to reproduce

Test sample: DemoConsole in Winforms repo

More Info:

This issue also reproduces on ImageList when clicking the "Add" command.
image
@Philip-Wang01 Philip-Wang01 added 💥 regression-preview Regression from a preview release untriaged The team needs to look at this issue in the next triage area-Serialization-BinaryFormatter-FeatureWork Feature work under the general area of BinaryFormatter related serialization labels Jun 28, 2024
@elachlan
Copy link
Contributor

Related to #9428 and #6267

We had similar issues when BinaryFormatter was marked as obsolete #9416

@elachlan elachlan mentioned this issue Jun 30, 2024
Closed
@LeafShi1
Copy link
Member

LeafShi1 commented Jul 3, 2024

This issue appears after PR #11540

@LeafShi1 LeafShi1 self-assigned this Jul 24, 2024
@LeafShi1
Copy link
Member

This issue disappear after add binary Formatter package (Related PR #11741)

@LeafShi1 LeafShi1 removed the untriaged The team needs to look at this issue in the next triage label Jul 24, 2024
@John-Qiao
Copy link
Member

Verified the issue on the latest DemoConsole test app of Winforms repo from main branch, it was fixed: no exception occurs when clicking "Add Tab" command for TabControl now.

11607-testresult2.mp4

@MelonWang1 MelonWang1 modified the milestones: 9.0 Preview7, 9.0 RC1 Jul 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LeafShi1 LeafShi1

Labels
area-Serialization-BinaryFormatter-FeatureWork Feature work under the general area of BinaryFormatter related serialization 💥 regression-preview Regression from a preview release
Projects
None yet
Milestone
9.0 RC1
Development

Successfully merging a pull request may close this issue.

Attempt to use BinaryFormattedObject/BinaryFormatWriter before BinaryFormatter elachlan/winforms
5 participants
@elachlan @John-Qiao @Philip-Wang01 @MelonWang1 @LeafShi1