SQLite Query: Should we be translating decimal/TimeSpan operations?

[bricelam]

Any operation (besides equality comparison) on decimal values will be lossy on SQLite since they are implicitly converted to REAL on the server. Should we continue translating them?

[smitpatel]

😢

[ajcvickers]

This is a specific case of the general problem described in #10265. Leaving this issue open as well since the two things may end up with different priorities.

[bricelam]

TimeSpan is plagued by the same problems--Min() and Max() do string comparison, etc.

[bricelam]

Found several more cases involving DateTime, DateTimeOffset, and ulong.

[bricelam]

Here's a table of the operations we should block server-eval for:

Expression	DateTime	DateTimeOffset	decimal	TimeSpan	ulong
-x			❌	❌	✔
x + y	❌	❌	❌	❌	✔
x / y			❌	❌	❌
x > y	✔	❌	❌	❌	❌
x >= y	✔	❌	❌	❌	❌
x < y	✔	❌	❌	❌	❌
x <= y	✔	❌	❌	❌	❌
x % y			❌		❌
x * y			❌	❌	❌
x - y	❌	❌	❌	❌	✔
xs.Average()			❌
xs.Max()		❌	❌	❌	❌
xs.Min()		❌	❌	❌	❌
xs.Sum()			❌		✔

[bricelam]

Filed #11925 for blocking GroupBy()