agent: shutdown connection on node stop #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think @aaronlehmann meant another connection. I think that connection can be just cleaned up with defer in |
Current coverage is 54.80% (diff: 0.00%)@@ master #1277 diff @@
==========================================
Files 78 78
Lines 12440 12429 -11
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6814 6812 -2
+ Misses 4683 4678 -5
+ Partials 943 939 -4
|
Indeed. Don't we still need to shut this one down? |
stevvooe
force-pushed
the
close-connection
branch
from
2950f77
to
9720c3a
Compare
|
@stevvooe At first I thought that yes, but now I believe that it will always be closed here https://github.com/stevvooe/swarmkit/blob/9720c3aff5db28dc5e46555b4e4c790bc9db392b/agent/node.go#L571 because context will be closed here https://github.com/stevvooe/swarmkit/blob/9720c3aff5db28dc5e46555b4e4c790bc9db392b/agent/node.go#L175 |
Signed-off-by: Stephen J Day <[email protected]>
stevvooe
force-pushed
the
close-connection
branch
from
9720c3a
to
f6abeca
Compare
|
@LK4D4 Fair enough. |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1274.
Signed-off-by: Stephen J Day [email protected]
cc @LK4D4 @aaronlehmann @tonistiigi