Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad order of iptables filter rules #961

Merged
merged 1 commit into from
Mar 6, 2017

Conversation

JrCs
Copy link
Contributor

@JrCs JrCs commented Feb 21, 2016

Rules with ctstate RELATED,ESTABLISHED must be create before same rules without ctstate.

See moby/moby#18911

@JrCs JrCs force-pushed the fix-iptables-order branch 3 times, most recently from ecc3a09 to 53d0c8a Compare February 24, 2016 12:44
@mavenugo
Copy link
Contributor

@aboch can you PTAL

@aboch
Copy link
Contributor

aboch commented Apr 12, 2016

I cannot get all the integ tests pass with this change.
@JrCs can you take a look:

sudo make clean integration-tests

(make sure to also patch 389d498)

Rules with ctstate RELATED,ESTABLISHED must be create before same
rules without ctstate.

Signed-off-by: Yves Blusseau <[email protected]>
@JrCs
Copy link
Contributor Author

JrCs commented Apr 17, 2016

I have rebase my PR.
All tests are now successful.

@aboch
Copy link
Contributor

aboch commented Apr 20, 2016

LGTM

@JrCs
Copy link
Contributor Author

JrCs commented Jun 28, 2016

Do you think it will be merge soon ?

@sanimej
Copy link

sanimej commented Mar 6, 2017

@JrCs Thanks and sorry about the really long delay. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants