remove COMMAND column from service ls output. closes #27994

[tealtail]

- What I did
removes COMMAND col from service ls output

- How to verify it
run tests, run docker service ls
- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Alicia Lauerman [email protected]

[aaronlehmann]

I'd vote for removing the COMMAND column instead. I don't think it's very useful. It would keep things simpler not thave this column at all.

[tealtail]

@aaronlehmann okay, yeah, that's much simpler :) I'll update this PR soon to remove the column

[thaJeztah]

We should think about adding a --format flag, so that users can customize the output. I'll check if there's an issue for that already, otherwise open one

[tealtail]

locally tests pass but the builds triggered by push here failed with

18:33:21 Error response from daemon: No such container: docker-pr-exp26009
[...]
18:33:41 Finished: FAILURE

[thaJeztah]

@tealtail looks like this is the actual failure;

20:58:29 ---> Making bundle: validate-vet (in bundles/1.13.0-dev/validate-vet)
20:58:29 cli/command/service/list.go:112: missing argument for Fprintf("%s"): format reads arg 5, have only 4 args
20:58:29 cli/command/service/list.go:120: missing argument for Fprintf("%s"): format reads arg 5, have only 4 args
20:58:29 exit status 1

[tealtail]

ohhh thanks @thaJeztah okay, so I'm thinking the problem is that listItemFmt would need 1 less %s now? I'm running tests after making that change and will update the PR again tonight

[tealtail]

all builds are passing now 👍

[thaJeztah]

Awesome!

design LGTM, but a quick check with @aluzzardi if he agrees

[aluzzardi]

LGTM

We actually discussed removing this column a few days ago as it was consuming precious screen real estate with no meaningful use, so 👍

[aaronlehmann]

LGTM

[thaJeztah]

docs changes here LGTM, but ping @mstanleyjones as it's possible other parts of the docs have some example output that needs to be updated

[mdlinville]

Does it also affect service update, service rm, service inspect, etc?

[tealtail]

@mstanleyjones yes! some of those still have COMMAND output included in examples. Update incoming.

[tealtail]

@mstanleyjones I've updated this PR with the changes you requested

[mdlinville]

LGTM. cc @allencloud please sync #27710 with this change.