api: fix corner case staggered fd for centered x0 #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2373 +/- ##
=======================================
Coverage 86.76% 86.76%
=======================================
Files 233 233
Lines 43741 43764 +23
Branches 8075 8079 +4
=======================================
+ Hits 37953 37973 +20
- Misses 5079 5080 +1
- Partials 709 711 +2 ☔ View full report in Codecov by Sentry. |
georgebisbas
approved these changes
May 20, 2024
mloubout
force-pushed
the
corner-stagg-fd
branch
3 times, most recently
from
e636dd5
to
48700a0
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
mloubout
force-pushed
the
corner-stagg-fd
branch
5 times, most recently
from
75c026d
to
20b69cf
Compare
FabioLuporini
approved these changes
May 20, 2024
mloubout
force-pushed
the
corner-stagg-fd
branch
2 times, most recently
from
76fc389
to
a5b12ed
Compare
mloubout
force-pushed
the
corner-stagg-fd
branch
2 times, most recently
from
9ea9d16
to
5b24aa8
Compare
FabioLuporini
approved these changes
May 21, 2024
|
thanks, nice cleanup, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for elastic tti that contains odd centering FD