compiler: Misc codegen enhancements #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloubout
approved these changes
Jan 30, 2024
| # Perform some basic simplifications at least | ||
| args = [i for i in args if i != 1] | ||
| if any(i == 0 for i in args): | ||
| return S.Zero |
There was a problem hiding this comment.
Can probably do S.One and S.negativeOne as well that have a bunch of special handling in sympy
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2300 +/- ##
==========================================
- Coverage 86.70% 86.69% -0.01%
==========================================
Files 229 229
Lines 42895 42928 +33
Branches 7952 7958 +6
==========================================
+ Hits 37190 37216 +26
- Misses 5022 5027 +5
- Partials 683 685 +2 ☔ View full report in Codecov by Sentry. |
georgebisbas
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.